Skip to content

Conversation

@shewu-quic
Copy link
Collaborator

summary:

  • Fix the 8a8w config in custom annotation
  • Enable to set act observer and symmetric argument for per channel quant
  • Remove unuse custom annotation in llama.py

…el quant

summary:
- Fix the 8a8w config in custom annotation
- Enable to set act observer and symmetic argument for per channel quant
- Remove unuse custom annotation in llama.py
@pytorch-bot
Copy link

pytorch-bot bot commented Nov 22, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7026

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 5d85cf1 with merge base 97b58bb (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 22, 2024
@shewu-quic
Copy link
Collaborator Author

Hi @cccclai,

The PR is to enable to set the act_observer for per-channel quant which to align the observer with other nodes.
Could you help to take a look?

Thanks,
Hutton

@cccclai
Copy link
Contributor

cccclai commented Nov 22, 2024

@navsud can you help with verifying

Copy link
Contributor

@navsud navsud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for the update... Without this, the act observers were not consistent across the graph, especially when we want to use MinMaxObserver for 16-bit activations.

Copy link
Contributor

@cccclai cccclai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@facebook-github-bot
Copy link
Contributor

@cccclai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cccclai cccclai merged commit a7ed425 into pytorch:main Nov 22, 2024
41 of 43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: misc Miscellaneous

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants