Skip to content

Conversation

@davidlin54
Copy link
Contributor

@davidlin54 davidlin54 commented Nov 25, 2024

fix test-llama-runner-qnn-linux (fp32, qnn)

  • add default value
  • change pull.yml to reflect same changes in trunk.yml

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 25, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7055

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures, 1 Unrelated Failure

As of commit 84ea1c2 with merge base fbee0c8 (image):

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 25, 2024
@davidlin54
Copy link
Contributor Author

@pytorchbot label "topic: misc"

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 25, 2024

Didn't find following labels among repository labels: topic: misc

@davidlin54
Copy link
Contributor Author

@pytorchbot label "topic: not user facing"

@davidlin54 davidlin54 changed the title fix pt2e Fix test-llama-runner-qnn-linux tests Nov 25, 2024
Copy link
Contributor

@swolchok swolchok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems fine? if failures are unrelated, ship it

@davidlin54 davidlin54 merged commit 04f9ced into main Nov 25, 2024
67 of 71 checks passed
@davidlin54 davidlin54 deleted the lind/fix_pt2e branch November 25, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants