sh clean.sh script that does cleaning #7108
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7108
Note: Links to docs will display an error until the docs builds have been completed. ❌ 2 New FailuresAs of commit 0b05f47 with merge base de74961 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
mergennachin
added
the
release notes: build
kirklandsign
approved these changes
Nov 27, 2024
clean.sh
Outdated
| # LICENSE file in the root directory of this source tree | ||
|
|
||
| set -eu | ||
| rm -rf cmake-out pip-out |
There was a problem hiding this comment.
Could also add cmake-android-out and cmake-out-android-*
There was a problem hiding this comment.
actually not creating sh.clean.sh anymore.
Reusing install_requirements.sh --clean instead.
mergennachin
force-pushed
the
my-fork
branch
from
6f9a7d5 to
0d398a3
Compare
Let's encapsulate important steps inside this single script for cleaning up. As next steps, I'd like to restart buck as part of this script. #7083
mergennachin
force-pushed
the
my-fork
branch
from
0d398a3 to
0b05f47
Compare
mergennachin
added a commit
that referenced
this pull request
Dec 12, 2024
After #7108 landed, it broke CI, in particular build-llm-demo test. Here's an example: https://github.com/pytorch/executorch/actions/runs/12301283060/job/34332275511#logs It removed a folder than contained android artifacts. Let's just revert back to 'rm -rf cmake-out'
mergennachin
added a commit
that referenced
this pull request
Dec 12, 2024
After #7108 landed, it broke CI, in particular build-llm-demo test. Here's an example: https://github.com/pytorch/executorch/actions/runs/12301283060/job/34332275511#logs It removed a folder than contained android artifacts. Let's just revert back to 'rm -rf cmake-out'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's encapsulate important steps inside this single script for cleaning up.
As next steps, I'd like to restart buck as part of this script.
#7083