Skip to content

Conversation

@neuropilot-captain
Copy link
Collaborator

@neuropilot-captain neuropilot-captain commented Nov 28, 2024

  • Adding CI for MediaTek backend
  • Add test to workflow

@pytorch-bot
Copy link

pytorch-bot bot commented Nov 28, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7120

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 New Failures

As of commit de7f99e with merge base db96aba (image):

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 28, 2024
@cccclai
Copy link
Contributor

cccclai commented Dec 3, 2024

Hmm, looks like we don't see the new CI job...

@neuropilot-captain neuropilot-captain changed the title [WIP] Add MediaTek backend CI Add MediaTek backend CI Dec 30, 2024
@cccclai
Copy link
Contributor

cccclai commented Jan 22, 2025

The Ci job shows up now, however it's failing...https://github.com/pytorch/executorch/actions/runs/12493398331/job/34923145038?pr=7120

@cccclai cccclai added the release notes: mediatek Changes to the Mediatek backend delegate label Feb 5, 2025
@cccclai
Copy link
Contributor

cccclai commented Feb 26, 2025

@huydhn @kirklandsign we're trying to add android build in this unit test (also a new docker image). Do we need to add these lines

# Install lintrunner if needed
COPY ./common/install_android.sh install_android.sh
RUN if [ -n "${ANDROID_NDK_VERSION}" ]; then bash ./install_android.sh; fi
RUN rm install_android.sh
to have android installed?

@kirklandsign
Copy link
Contributor

to have android installed

Yes, if you need NDK build (which is true in this case right?)

@cccclai
Copy link
Contributor

cccclai commented Mar 5, 2025

@kirklandsign
Copy link
Contributor

Also need ANDROID_NDK_VERSION=r27b here?

executorch-ubuntu-22.04-mediatek-sdk)
MEDIATEK_SDK=yes
CLANG_VERSION=12
;;

@facebook-github-bot
Copy link
Contributor

@cccclai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

Copy link
Contributor

@cccclai cccclai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow the CI is working, awesome!

@facebook-github-bot
Copy link
Contributor

@cccclai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@cccclai cccclai merged commit f476f50 into pytorch:main Jun 12, 2025
187 of 189 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: mediatek Changes to the Mediatek backend delegate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants