Don't apply path rewriting rules for //executorch_models #7155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: ExecuTorch buck targets have rules to avoid explicit //xplat/executorch references. Due to the way this works, it is also blocking references to //xplat/executorch_models, but does not properly rewrite paths for this case. This change updates the //executorch check to //executorch/ or //executorch:, allowing the executorch_models deps to be used. Differential Revision: D66685959
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7155
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 7b4ad69 with merge base 5f0a14a ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66685959 |
larryliu0820
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: ExecuTorch buck targets have rules to avoid explicit //xplat/executorch references. Due to the way this works, it is also blocking references to //xplat/executorch_models, but does not properly rewrite paths for this case. This change updates the //executorch check to //executorch/ or //executorch:, allowing the executorch_models deps to be used.
Differential Revision: D66685959