Added support for torch.concat operator. #7161
Conversation
Added torch.ops.aten.concatenate.default in the list of supported operators in the generic annotator. Also added a test to check the functionality of the newly added operator. Change-Id: I24d0fbf96bf9fd57ebd059cefd2af0f525fe8235
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7161
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 8e912a5 with merge base f6a87ac ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
zingo
added
partner: arm
|
Please seek CI approval before scheduling CIFlow labels |
| torch.ops.aten.tile.default, | ||
| torch.ops.aten.flip.default, | ||
| torch.ops.aten.cat.default, | ||
| torch.ops.aten.concatenate.default, |
There was a problem hiding this comment.
Do we really see this op after export?
There was a problem hiding this comment.
This issue was noticed during internal testing after export and thus this PR was needed to fix this issue.
|
@Michiel-Olieslagers pls re-run CI since the PR merged this morning re-enables some tests. Thx |
facebook-github-bot
added
the
CLA Signed
|
pull / unittest / linux / linux-job (pull_request) job is failing due to a URL 404 error not related to this PR. |
5 participants
Added torch.ops.aten.concatenate.default in the list of supported operators in the generic annotator. This allows torch.concat operators to be lowered to aten.
Also added a test to check the functionality of the newly added operator to ensure functionality of added operator is preserved in future.