Handle existing directory when extracting benchmark result #7171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7171
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 11b562e with merge base ac8bf78 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
huydhn
temporarily deployed
to
upload-benchmark-results
GitHub Actions
Inactive
kirklandsign
approved these changes
Dec 4, 2024
guangy10
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a mistake in #7117 and didn't handle the case where the output directory already exists. This happens when there are multiple models to test and the upload job handles all of them in one go, for example https://github.com/pytorch/executorch/actions/runs/12151259880/job/33888145249#step:7:55
Testing
https://github.com/pytorch/executorch/actions/runs/12155146995 with 2 models running in parallel to confirm that an existing output directory is handled correctly.