improve error messaging in to_edge_transform_and_lower #7184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7184
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit bd19f19 with merge base a9565aa ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66787170 |
tarun292
approved these changes
Dec 4, 2024
mcr229
added a commit
to mcr229/executorch
that referenced
this pull request
Dec 5, 2024
Summary: when sanity checks fail, the error message isn't super useful because we don't know what node or what op target is the violating one. We improve the error message here so that we can see what it is. Reviewed By: tarun292 Differential Revision: D66787170
mcr229
force-pushed
the
export-D66787170
branch
from
da63cae to
bc25e88
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66787170 |
mcr229
added a commit
to mcr229/executorch
that referenced
this pull request
Dec 5, 2024
Summary: when sanity checks fail, the error message isn't super useful because we don't know what node or what op target is the violating one. We improve the error message here so that we can see what it is. Reviewed By: tarun292 Differential Revision: D66787170
mcr229
force-pushed
the
export-D66787170
branch
from
bc25e88 to
c76d972
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66787170 |
Summary: when sanity checks fail, the error message isn't super useful because we don't know what node or what op target is the violating one. We improve the error message here so that we can see what it is. Reviewed By: tarun292 Differential Revision: D66787170
mcr229
force-pushed
the
export-D66787170
branch
from
c76d972 to
bd19f19
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D66787170 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: when sanity checks fail, the error message isn't super useful because we don't know what node or what op target is the violating one. We improve the error message here so that we can see what it is.
Differential Revision: D66787170