restucture debug handle #7197
Merged
restucture debug handle #7197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Differential Revision: [D66622890](https://our.internmc.facebook.com/intern/diff/D66622890/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7197
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 100c16a with merge base de74961 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Gasoonjia
added a commit
that referenced
this pull request
Dec 5, 2024
Differential Revision: [D66622890](https://our.internmc.facebook.com/intern/diff/D66622890/) ghstack-source-id: 256664831 Pull Request resolved: #7197
|
This pull request was exported from Phabricator. Differential Revision: D66622890 |
jerryzh168
approved these changes
Dec 10, 2024
jerryzh168
reviewed
Dec 10, 2024
|
|
||
| # TODO(gasoonjia): remove this and leverage core pytorch bfs_trace_with_node_process after code freeze | ||
| def bfs_trace_with_node_process( | ||
| gm: torch.fx.GraphModule, node_op: Callable[[torch.fx.Node], None] |
There was a problem hiding this comment.
this one takes gm? I remember another one takes ep? maybe align?
There was a problem hiding this comment.
There're two bfs_trace_with_node_process, one is under ao, the other is under et.
ao's take ep and gm while et's only takes gm.
I'm ok to unify them together, just believe not that necessary, since it is an internal utility function, not an api for users to use.
Differential Revision: [D66622890](https://our.internmc.facebook.com/intern/diff/D66622890/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D66622890 |
Gasoonjia
added a commit
that referenced
this pull request
Dec 12, 2024
Pull Request resolved: #7197 This diff formats the debug handle generation process in et stack by. extracting bfs graph tracing process. ghstack-source-id: 257377901 @exported-using-ghexport Differential Revision: [D66622890](https://our.internmc.facebook.com/intern/diff/D66622890/)
|
@pytorchbot label "topic: not user facing" |
Differential Revision: [D66622890](https://our.internmc.facebook.com/intern/diff/D66622890/) [ghstack-poisoned]
Gasoonjia
added a commit
that referenced
this pull request
Dec 12, 2024
Pull Request resolved: #7197 This diff formats the debug handle generation process in et stack by. extracting bfs graph tracing process. ghstack-source-id: 257880795 @exported-using-ghexport Differential Revision: [D66622890](https://our.internmc.facebook.com/intern/diff/D66622890/)
|
This pull request was exported from Phabricator. Differential Revision: D66622890 |
facebook-github-bot
merged commit 435d273
into
gh/Gasoonjia/5/base
44 of 46 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
kirklandsign
pushed a commit
that referenced
this pull request
Dec 16, 2024
Pull Request resolved: #7197 This diff formats the debug handle generation process in et stack by. extracting bfs graph tracing process. ghstack-source-id: 257880795 @exported-using-ghexport Differential Revision: [D66622890](https://our.internmc.facebook.com/intern/diff/D66622890/) Co-authored-by: gasoonjia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Differential Revision: D66622890