Skip to content

[ET-VK] Replace Uniform buffers with push constants for view op #7229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Dec 13, 2024
Merged

[ET-VK] Replace Uniform buffers with push constants for view op #7229

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
40fd574
[ET-VK] Replace Uniform buffers with push constants for view op
trivedivivek Dec 6, 2024
501484e
Update on "[ET-VK] Replace Uniform buffers with push constants for vi…
trivedivivek Dec 6, 2024
5bc6d0c
Update on "[ET-VK] Replace Uniform buffers with push constants for vi…
trivedivivek Dec 6, 2024
73cf011
Update on "[ET-VK] Replace Uniform buffers with push constants for vi…
trivedivivek Dec 9, 2024
40330f4
Update on "[ET-VK] Replace Uniform buffers with push constants for vi…
trivedivivek Dec 9, 2024
8d94305
Update on "[ET-VK] Replace Uniform buffers with push constants for vi…
trivedivivek Dec 10, 2024
425989f
Update on "[ET-VK] Replace Uniform buffers with push constants for vi…
trivedivivek Dec 11, 2024
9fde95a
Update on "[ET-VK] Replace Uniform buffers with push constants for vi…
trivedivivek Dec 11, 2024
7e35fe6
Update on "[ET-VK] Replace Uniform buffers with push constants for vi…
trivedivivek Dec 12, 2024
2dab102
Update on "[ET-VK] Replace Uniform buffers with push constants for vi…
trivedivivek Dec 12, 2024
c0f8d11
Update on "[ET-VK] Replace Uniform buffers with push constants for vi…
trivedivivek Dec 12, 2024
04fc85f
Update on "[ET-VK] Replace Uniform buffers with push constants for vi…
trivedivivek Dec 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions backends/vulkan/runtime/graph/ops/glsl/view.glsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,10 @@ layout(std430) buffer;
${layout_declare_tensor(0, "w", "t_out", DTYPE, STORAGE)}
${layout_declare_tensor(1, "r", "t_in", DTYPE, STORAGE)}

${layout_declare_ubo(2, "ivec4", "out_sizes")}
${layout_declare_ubo(3, "ivec4", "in_sizes")}
layout(push_constant) uniform PRECISION restrict Block {
ivec4 out_sizes;
ivec4 in_sizes;
};

layout(local_size_x_id = 0, local_size_y_id = 1, local_size_z_id = 2) in;

Expand Down
6 changes: 4 additions & 2 deletions backends/vulkan/runtime/graph/ops/impl/View.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,12 +76,14 @@ void add_view_node(
{{out, vkapi::MemoryAccessType::WRITE},
{in, vkapi::MemoryAccessType::READ}},
// Parameter Buffers
{t_out->sizes_ubo(), t_in->sizes_ubo()},
{},
// Specialization Constants
{SV(t_in->packed_dim()), SV(t_out->packed_dim())},
// Resizing Logic
resize_view_node,
{sizes}));
{sizes},
// Push Constants
{{graph.sizes_pc_of(out), graph.sizes_pc_of(in)}}));
}

void view(ComputeGraph& graph, const std::vector<ValueRef>& args) {
Expand Down