Skip to content

Patch llama.py for internal build #7239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 10, 2024
Merged

Patch llama.py for internal build #7239

merged 1 commit into from
Dec 10, 2024

Conversation

@cccclai
Copy link
Contributor

@cccclai cccclai commented Dec 9, 2024

Summary:
As title, minor changes so we can use buck to build..

buck run mode/dev-nosan //executorch/examples/qualcomm/oss_scripts/llama3_2:llama_qnn -- --compile_only --ptq 16a4w --checkpoint /home/chenlai/local/models/consolidated.00.pth --params /home/chenlai/local/models/params.json --tokenizer_model /home/chenlai/local/models/tokenizer.model --prompt "Once" -m SM8650 --model_size 1B --model_mode kv  2>&1 | tee static_llama.log

Differential Revision: D66947240

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 9, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7239

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 New Failure, 1 Unrelated Failure

As of commit 2789358 with merge base f22d1a3 (image):

NEW FAILURE - The following job has failed:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 9, 2024
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Dec 9, 2024

This pull request was exported from Phabricator. Differential Revision: D66947240

@github-actions
Copy link

github-actions bot commented Dec 9, 2024

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

shewu-quic
shewu-quic approved these changes Dec 9, 2024
View reviewed changes
Copy link
Collaborator

@shewu-quic shewu-quic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Thanks for your patch.

cccclai added a commit to cccclai/executorch-1 that referenced this pull request Dec 9, 2024
@cccclai @facebook-github-bot
Patch llama.py for internal build (pytorch#7239)
c8adafa 
Summary:

As title, minor changes so we can use buck to build..

```
buck run mode/dev-nosan //executorch/examples/qualcomm/oss_scripts/llama3_2:llama_qnn -- --compile_only --ptq 16a4w --checkpoint /home/chenlai/local/models/consolidated.00.pth --params /home/chenlai/local/models/params.json --tokenizer_model /home/chenlai/local/models/tokenizer.model --prompt "Once" -m SM8650 --model_size 1B --model_mode kv  2>&1 | tee static_llama.log
```

Differential Revision: D66947240
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Dec 9, 2024

This pull request was exported from Phabricator. Differential Revision: D66947240

@cccclai @facebook-github-bot
Patch llama.py for internal build (pytorch#7239)
2789358 
Summary:

As title, minor changes so we can use buck to build..

```
buck run mode/dev-nosan //executorch/examples/qualcomm/oss_scripts/llama3_2:llama_qnn -- --compile_only --ptq 16a4w --checkpoint /home/chenlai/local/models/consolidated.00.pth --params /home/chenlai/local/models/params.json --tokenizer_model /home/chenlai/local/models/tokenizer.model --prompt "Once" -m SM8650 --model_size 1B --model_mode kv  2>&1 | tee static_llama.log
```

Differential Revision: D66947240
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Dec 10, 2024

This pull request was exported from Phabricator. Differential Revision: D66947240

@cccclai cccclai merged commit 5161d70 into pytorch:main Dec 10, 2024
42 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kirklandsign kirklandsign kirklandsign approved these changes

@chunit-quic chunit-quic Awaiting requested review from chunit-quic

@haowhsu-quic haowhsu-quic Awaiting requested review from haowhsu-quic

@winskuo-quic winskuo-quic Awaiting requested review from winskuo-quic

+1 more reviewer

@shewu-quic shewu-quic shewu-quic approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cccclai @facebook-github-bot @kirklandsign @shewu-quic