Generalize all annotators into a generic parameterizable annotator #7298
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7298
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 4482e4e with merge base 241cd0c ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Tessil
added
partner: arm
Tessil
force-pushed
the
toupstream/generic_annotator
branch
from
b234dad to
261748a
Compare
zkhin
approved these changes
Dec 15, 2024
Collaborator
|
@Tessil, rebase pls |
Change-Id: I69ecdbef9d7b83a87655e97758215303374b5f04
Tessil
force-pushed
the
toupstream/generic_annotator
branch
from
261748a to
4482e4e
Compare
Collaborator
Author
|
Change rebased and rebase conflicts fixed. |
freddan80
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR is a general refactoring of the backend quantizer removing all the
backends/arm/quantizer/quantization_annotation/*annotators and centralize them into a more generic and configurablequantization_annotator.py.With the removal of
OperatorConfig, it also removes the unusedget_supported_*ops as they were not maintained nor used. But these can be kept if necessary or the change moved into another PR.