Skip to content

Add util function for pretty printing of output diffs #7302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 19, 2024
Merged

Add util function for pretty printing of output diffs #7302

merged 7 commits into from
Dec 19, 2024

Conversation

@AdrianLundell
Copy link
Collaborator

@AdrianLundell AdrianLundell commented Dec 12, 2024

The function is added as a callback to run_method_and_compare_outputs to open up for other types of analyze methods in the future.

@AdrianLundell
Add util function for pretty printing of output diffs
c1915f1 
Change-Id: I93416fe3f2c175050b84a16004bf32849bafd1fe
@AdrianLundell AdrianLundell added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk topic: not user facing labels Dec 12, 2024
@pytorch-bot
Copy link

pytorch-bot bot commented Dec 12, 2024 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7302

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 329cbad with merge base c1e137b (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 12, 2024
@AdrianLundell
Copy link
Collaborator Author

AdrianLundell commented Dec 13, 2024

Unrelated CI failure in

freddan80
freddan80 reviewed Dec 13, 2024
View reviewed changes
@freddan80
Copy link
Collaborator

freddan80 commented Dec 17, 2024

Rebase pls

@AdrianLundell
Merge branch 'main' of https://github.com/pytorch/executorch into dev…
12771e3 
…/analyze_output_utils
@AdrianLundell
Move callbacks into _compare_outputs
0066e87 
This is to make run_method_and_compare_outputs less complex since lintrunner was complaining.
Additionally moves out previous info dumps in compare_output into a new callback function to handle all error handling in the same way.

Change-Id: If7c7cfd515d4870c018a34785dd80be15d4fbcef
@AdrianLundell
Copy link
Collaborator Author

AdrianLundell commented Dec 18, 2024

Unrelated CI error when running

curl -Lo /tmp/v2.25.0.24.07.28.zip https://softwarecenter.qualcomm.com/api/download/software/qualcomm_neural_processing_sdk/v2.25.0.240728.zip 
...
2024-12-18T08:56:22.4369579Z curl: (92) HTTP/2 stream 0 was not closed cleanly: INTERNAL_ERROR (err 2)
2024-12-18T08:56:22.4370216Z     raise RuntimeError(f"Command {cmd} failed with exit code {exit_code}")

@freddan80 freddan80 merged commit c337bef into pytorch:main Dec 19, 2024
107 checks passed
@AdrianLundell AdrianLundell deleted the dev/analyze_output_utils branch March 19, 2025 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@freddan80 freddan80 freddan80 approved these changes

Assignees

No one assigned

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AdrianLundell @freddan80 @facebook-github-bot