Refer "./install_requirements.sh --clean" in documents #7303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7303
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (1 Unrelated Failure)As of commit 79d3d30 with merge base df0b06c ( BROKEN TRUNK - The following job failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
mergennachin
added
the
release notes: build
Contributor
Author
|
Corresponding GH issue: #7083 |
mergennachin
force-pushed
the
my-fork2
branch
from
4d9eb97 to
c28586f
Compare
guangy10
reviewed
Dec 12, 2024
|
|
||
| set(resolve_buck2_command | ||
| ${PYTHON_EXECUTABLE} ${executorch_root}/build/resolve_buck.py | ||
| --cache_dir=${CMAKE_CURRENT_BINARY_DIR}/buck2-bin |
Contributor
There was a problem hiding this comment.
Move the buck2-bin to root dir, so that it can be cleaned up? Isn't already covered by cleaning up CMAKE_CURRENT_BINARY_DIR (i.e. cmake-out)?
Contributor
Author
There was a problem hiding this comment.
Yeah, did that here
Summary: Currently, most documents will explicitly ask users to run "rm -rf" But we have a dedicated command that does the cleanup.
mergennachin
force-pushed
the
my-fork2
branch
from
c28586f to
79d3d30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Currently, most documents will explicitly ask users to run "rm -rf"
But we have a dedicated command that does the cleanup.
Fixes #7083
Test plan
Reproduced all the commands in the .md file. Fixed some of the existing bugs, for instance, in QNN command.