Allow backends/cadence to use TestUtil.h. #7304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Open

hsharma35 wants to merge 1 commit into pytorch:main from hsharma35:export-D67128600

Contributor

hsharma35 commented Dec 12, 2024

Summary: Create a separate buck target for TestUtil.h that can be used by backends. The current test_util target has dependencies that don't compile for xtensa toolchain.

Differential Revision: D67128600

pytorch-bot bot commented Dec 12, 2024 •

edited

Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7304

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 3a9fcee with merge base 61b9e1b ():
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

facebook-github-bot added the CLA Signed label

Contributor

facebook-github-bot commented Dec 12, 2024

This pull request was exported from Phabricator. Differential Revision: D67128600

facebook-github-bot added the fb-exported label

Contributor Author

hsharma35 commented Dec 12, 2024

@pytorchbot label "topic: not user facing"

pytorch-bot bot added the topic: not user facing label

hsharma35 requested review from facebook-github-bot and swolchok

December 12, 2024 18:22

hsharma35 added a commit to hsharma35/executorch that referenced this pull request


          Allow backends/cadence to use TestUtil.h. (pytorch#7304)

5198e99

Summary:

Create a separate buck target for `TestUtil.h` that can be used by backends. The current `test_util` target has dependencies that don't compile for xtensa toolchain.

Differential Revision: D67128600

hsharma35 force-pushed the export-D67128600 branch from a84f6c0 to 5198e99 Compare

December 12, 2024 18:30

Contributor

facebook-github-bot commented Dec 12, 2024

This pull request was exported from Phabricator. Differential Revision: D67128600

hsharma35 requested review from tarun292 and zonglinpeng

December 12, 2024 18:39

zonglinpeng approved these changes

View reviewed changes

zonglinpeng approved these changes

View reviewed changes

hsharma35 added a commit to hsharma35/executorch that referenced this pull request


          Allow backends/cadence to use TestUtil.h. (pytorch#7304)

2d67eb1

Summary:

Create a separate buck target for `TestUtil.h` that can be used by backends. The current `test_util` target has dependencies that don't compile for xtensa toolchain.

Reviewed By: zonglinpeng

Differential Revision: D67128600

hsharma35 force-pushed the export-D67128600 branch from 5198e99 to 2d67eb1 Compare

December 12, 2024 19:04

Contributor

facebook-github-bot commented Dec 12, 2024

This pull request was exported from Phabricator. Differential Revision: D67128600

hsharma35 added a commit to hsharma35/executorch that referenced this pull request


          Allow backends/cadence to use TestUtil.h. (pytorch#7304)

Summary:

Create a separate buck target for `TestUtil.h` that can be used by backends. The current `test_util` target has dependencies that don't compile for xtensa toolchain.

Reviewed By: zonglinpeng

Differential Revision: D67128600

hsharma35 force-pushed the export-D67128600 branch from 2d67eb1 to 5660139 Compare

December 12, 2024 19:19

Contributor

facebook-github-bot commented Dec 12, 2024

This pull request was exported from Phabricator. Differential Revision: D67128600

hsharma35 added a commit to hsharma35/executorch that referenced this pull request


          Allow backends/cadence to use TestUtil.h. (pytorch#7304)

814978b

Summary:

Create a separate buck target for `TestUtil.h` that can be used by backends. The current `test_util` target has dependencies that don't compile for xtensa toolchain.

Reviewed By: zonglinpeng

Differential Revision: D67128600

hsharma35 added a commit to hsharma35/executorch that referenced this pull request


          Allow backends/cadence to use TestUtil.h. (pytorch#7304)

2f90421

Summary:

Create a separate buck target for `TestUtil.h` that can be used by backends. The current `test_util` target has dependencies that don't compile for xtensa toolchain.

Reviewed By: zonglinpeng

Differential Revision: D67128600

hsharma35 added a commit to hsharma35/executorch that referenced this pull request


          Allow backends/cadence to use TestUtil.h. (pytorch#7304)

b354f46

Summary:

Create a separate buck target for `TestUtil.h` that can be used by backends. The current `test_util` target has dependencies that don't compile for xtensa toolchain.

Reviewed By: zonglinpeng

Differential Revision: D67128600

hsharma35 added a commit to hsharma35/executorch that referenced this pull request


          Allow backends/cadence to use TestUtil.h. (pytorch#7304)

9b4a784

Summary:

Create a separate buck target for `TestUtil.h` that can be used by backends. The current `test_util` target has dependencies that don't compile for xtensa toolchain.

Reviewed By: zonglinpeng

Differential Revision: D67128600

hsharma35 added a commit to hsharma35/executorch that referenced this pull request


          Allow backends/cadence to use TestUtil.h. (pytorch#7304)

34c5d52

Summary:

Create a separate buck target for `TestUtil.h` that can be used by backends. The current `test_util` target has dependencies that don't compile for xtensa toolchain.

Reviewed By: zonglinpeng

Differential Revision: D67128600

hsharma35 force-pushed the export-D67128600 branch from 5660139 to 34c5d52 Compare

December 12, 2024 23:27

Contributor

facebook-github-bot commented Dec 12, 2024

This pull request was exported from Phabricator. Differential Revision: D67128600

hsharma35 added a commit to hsharma35/executorch that referenced this pull request


          Allow backends/cadence to use TestUtil.h. (pytorch#7304)

290fbb9

Summary:

Create a separate buck target for `TestUtil.h` that can be used by backends. The current `test_util` target has dependencies that don't compile for xtensa toolchain.

Reviewed By: zonglinpeng

Differential Revision: D67128600

hsharma35 force-pushed the export-D67128600 branch from 34c5d52 to 290fbb9 Compare

December 12, 2024 23:28

Contributor

facebook-github-bot commented Dec 12, 2024

This pull request was exported from Phabricator. Differential Revision: D67128600


          Allow backends/cadence to use TestUtil.h. (pytorch#7304)

3a9fcee

Summary:

Create a separate buck target for `TestUtil.h` that can be used by backends. The current `test_util` target has dependencies that don't compile for xtensa toolchain.

Reviewed By: zonglinpeng

Differential Revision: D67128600

hsharma35 force-pushed the export-D67128600 branch from 290fbb9 to 3a9fcee Compare

December 12, 2024 23:29

Contributor

facebook-github-bot commented Dec 12, 2024

This pull request was exported from Phabricator. Differential Revision: D67128600

hsharma35 added a commit that referenced this pull request


          FusionG3 operators. (#7315)

6941d46

* Allow backends/cadence to use TestUtil.h. (#7304)

Summary:

Create a separate buck target for `TestUtil.h` that can be used by backends. The current `test_util` target has dependencies that don't compile for xtensa toolchain.

Reviewed By: zonglinpeng

Differential Revision: D67128600

* Xtensa ISS PAL layer for logging/timing. (#7311)

Summary:

Overrides for `et_pal*` weak symbols for logging/timing with xtensa ISS.

Reviewed By: zonglinpeng

Differential Revision: D67128599

* Use macro `XT_KERNEL_CHECK` to handle errors returned by nnlib. (#7312)

Summary:

Use ET_KERNEL_CHECK to detect error codes returned by xa_nn* library calls.

Reviewed By: zonglinpeng

Differential Revision: D67128597

* Separate buck targets per operator. (#7314)

Summary:

Keep targets separate so we only compile the operators we need.

Reviewed By: zonglinpeng

Differential Revision: D67128598

* FusionG3 operators. (#7315)

Summary:

Cleanup header order and `using` declarations for operators to match style guide.

Reviewed By: zonglinpeng

Differential Revision: D67128499

github-actions bot commented Aug 29, 2025

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

github-actions bot added the stale label

github-actions bot commented Oct 29, 2025

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed fb-exported stale topic: not user facing