Skip to content

Conversation

@hsharma35
Copy link
Contributor

Summary: Cleanup header order and using declarations for operators to match style guide.

Reviewed By: zonglinpeng

Differential Revision: D67128499

@pytorch-bot
Copy link

pytorch-bot bot commented Dec 12, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7315

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 9d9f728 with merge base 61b9e1b (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 12, 2024
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67128499

Summary:

Create a separate buck target for `TestUtil.h` that can be used by backends. The current `test_util` target has dependencies that don't compile for xtensa toolchain.

Reviewed By: zonglinpeng

Differential Revision: D67128600
Summary:

Overrides for `et_pal*` weak symbols for logging/timing with xtensa ISS.

Reviewed By: zonglinpeng

Differential Revision: D67128599
…rch#7312)

Summary:

Use ET_KERNEL_CHECK to detect error codes returned by xa_nn* library calls.

Reviewed By: zonglinpeng

Differential Revision: D67128597
Summary:

Keep targets separate so we only compile the operators we need.

Reviewed By: zonglinpeng

Differential Revision: D67128598
Summary:

Cleanup header order and `using` declarations for operators to match style guide.

Reviewed By: zonglinpeng

Differential Revision: D67128499
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D67128499

@hsharma35 hsharma35 merged commit 6941d46 into pytorch:main Dec 12, 2024
42 of 45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported topic: not user facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants