Arm backend: Add MM to BMM pass #7341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sebastian-Larsson
added
the
partner: arm
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7341
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit c704647 with merge base b16271c ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Collaborator
Author
|
@pytorchbot label ciflow/trunk |
Collaborator
|
Rebase pls |
Collaborator
Author
|
Rebase done! |
Collaborator
|
Rebase pls |
aten.mm does not support input or output tensors of rank 3, which is required by TOSA for the MM operation. Therefore, create a pass that converts any MM nodes to BMM (which always has rank 3). The pass also unsqueezes tensors of rank 2 to rank 3. As a result of the new pass, op_mm.py is no longer required and has been removed. Signed-off-by: Sebastian Larsson <[email protected]> Change-Id: I8459dd73bb366452b5139b48a5724c300b2d5a26
Sebastian-Larsson
force-pushed
the
main
branch
from
718d827 to
1df9dc8
Compare
Collaborator
Author
|
Rebase done |
freddan80
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aten.mm does not support input or output tensors of rank 3, which is
required by TOSA for the MM operation. Therefore, create a pass that
converts any MM nodes to BMM (which always has rank 3). The pass also
unsqueezes tensors of rank 2 to rank 3.
As a result of the new pass, op_mm.py is no longer required and has
been removed.
Signed-off-by: Sebastian Larsson [email protected]