Revert "Revert "Add full operator to fold dq/q handling" (#7351)" #7362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7362
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 9cd20c4 with merge base f341da8 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
per
added
ciflow/trunk
topic: not user facing
partner: arm
Collaborator
Author
|
@digantdesai Added this here to try to sort out the issues with the changes. |
Contributor
|
For some reason I can't import it internally ATM :( |
Contributor
|
@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
1 similar comment
Contributor
|
@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Collaborator
Author
|
Failures due to conda.anaconda.org gives |
Contributor
|
@per more type checker gifts for you |
Collaborator
Author
|
Unrelated failure in pull / unittest / macos / macos-job |
Contributor
|
@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
|
Still some more :( |
Contributor
|
@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
1 similar comment
Contributor
|
@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
This reverts commit 44e31fb. Change-Id: I12d88419e45a800e43e1e31d21280bc3b63710c6
This reverts commit 11beed1. Change-Id: I6ba9b37f069c3ad819114fe1384659bc0f68135f
Signed-off-by: Per Åstrand <[email protected]> Change-Id: Iee35eeb4af28a037848570b1d5143380222f549d
Signed-off-by: Per Åstrand <[email protected]> Change-Id: I60fb32ad55a3f6d3617993481ab0c1ed46cf778c
Change-Id: I37fb7468b5cb040b916fabb2784ec475318bddba
lintrunner moved the pyre-ignores to the wrong line, re-apply to the right line again. Signed-off-by: Per Åstrand <[email protected]> Change-Id: Icbb6cf6f2d65d6fe1c00e7c4a738691ffeb7acb2
Contributor
|
@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
digantdesai
reviewed
Dec 20, 2024
Contributor
digantdesai
left a comment
digantdesai
left a comment
There was a problem hiding this comment.
Thank you @per for all the back and forth.
digantdesai
approved these changes
Dec 20, 2024
digantdesai
approved these changes
Dec 20, 2024
digantdesai
approved these changes
Dec 20, 2024
digantdesai
approved these changes
Dec 20, 2024
oscarandersson8218
added a commit
to oscarandersson8218/executorch
that referenced
this pull request
Dec 20, 2024
Address issues from pyre and add similar # pyre-ignores as in pytorch#7362. Signed-off-by: Oscar Andersson <[email protected]> Change-Id: I6feaa611dcd539b3b0d21a6a7dd696ef7db691ef
oscarandersson8218
added a commit
to oscarandersson8218/executorch
that referenced
this pull request
Dec 30, 2024
Address issues from pyre and add similar # pyre-ignores as in pytorch#7362. Signed-off-by: Oscar Andersson <[email protected]> Change-Id: I6feaa611dcd539b3b0d21a6a7dd696ef7db691ef
digantdesai
pushed a commit
that referenced
this pull request
Jan 7, 2025
* Add TOSA table as custom edge op Edge operators that are lowered to TOSA TABLEs are convereted to a custom edge IR table-op. Signed-off-by: Oscar Andersson <[email protected]> Change-Id: I147008c30b9b46c7b8ae1a1c15bc540fea614a69 * Add support for concat q/dq folding This is a special case where node.args can be lists with many incoming dq-nodes. Signed-off-by: Oscar Andersson <[email protected]> Change-Id: Icf511a8bdeaaffb597b18455ab7f1fbd947ce3ca * Increase q/dq folding coverage Add support for q/dq folding of more operators such as hardtanh, maxpool2d, mul, relu, select, sub, to_copy. Signed-off-by: Oscar Andersson <[email protected]> Change-Id: Ifdabda4c927dade41c000859054696844c546f7b * Add support for sum q/dq folding sum is retraced to an int64 dtype of operator after q/dq folding. This patch adds a pass to manually force the dtype to be int8. Signed-off-by: Oscar Andersson <[email protected]> Change-Id: Ifa737a398c5a878d52cd76a2392499905da085ce * Complete q/dq folding coverage Add support for q/dq folding for the remaining supported ops in Arm backend. Signed-off-by: Oscar Andersson <[email protected]> Change-Id: I9012b4a501ce018c9771c729706be3b031a5c7ae * Remove is_quant_node from NodeVisitor.define_node Signed-off-by: Oscar Andersson <[email protected]> Change-Id: Ibb17add461dc79e022a7f4accde29f9f9d61b16d * Fix pyre issues Address issues from pyre and add similar # pyre-ignores as in #7362. Signed-off-by: Oscar Andersson <[email protected]> Change-Id: I6feaa611dcd539b3b0d21a6a7dd696ef7db691ef --------- Signed-off-by: Oscar Andersson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 11beed1.
Re-enable the passes to fold Q/DQ nodes in Arm delegate.