Skip to content

Fixed always rebuild issue in cmake. #7512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dbort merged 2 commits into from
Jan 16, 2025
Merged

Fixed always rebuild issue in cmake. #7512

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a85610a
Fixed always rebuild issue in cmake.
cptspacemanspiff Jan 4, 2025
32d0b14
Added common variable for schema output directory and removed acciden…
cptspacemanspiff Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions schema/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,10 @@ function(generate_program_schema _schema_srcs _schema_name)
foreach(fbs_file ${_schema_srcs})
string(REGEX REPLACE "[.]fbs$" "_generated.h" generated "${fbs_file}")
list(APPEND _schema_outputs
"${_program_schema__include_dir}/executorch/${generated}"
"${_program_schema__include_dir}/executorch/schema/${generated}"
Copy link
Contributor

@dbort dbort Jan 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The underlying problem was that this path didn't match the path in the custom_command. To make it more clear that they need to agree, and to avoid mismatches in the future, consider using a common local variable for both of them, like

set(_include_dir "${_program_schema__include_dir}/executorch/schema")

and then

list(APPEND _schema_outputs "${_include_dir}/${generated}")

here and again using _include_dir on line 38.

Copy link
Contributor Author

@cptspacemanspiff cptspacemanspiff Jan 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to this, named it _program_schema__output_dir to be a little more clear.

)
endforeach()

Copy link
Contributor

@dbort dbort Jan 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove these stray trailing whitespace characters

Copy link
Contributor Author

@cptspacemanspiff cptspacemanspiff Jan 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, removed that.

# Generate the headers from the .fbs files.
add_custom_command(
OUTPUT ${_schema_outputs}
Expand Down
Loading