Skip to content

Conversation

@mergennachin
Copy link
Contributor

@mergennachin mergennachin commented Jan 6, 2025

Summary

Looks like we never updated this value for 0.4 release.

Will do this change and cherry-pick onto 0.5 instead.

Test plan

Inspection

@pytorch-bot
Copy link

pytorch-bot bot commented Jan 6, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7520

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit aea577e with merge base 7a2dc47 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 6, 2025
@mergennachin mergennachin requested a review from dbort January 6, 2025 16:18
Copy link
Contributor

@dbort dbort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@dbort
Copy link
Contributor

dbort commented Jan 8, 2025

Worth picking this into the v0.5.0 release

@mergennachin mergennachin merged commit 54f0786 into main Jan 8, 2025
44 of 46 checks passed
@mergennachin mergennachin deleted the setup_py branch January 8, 2025 02:13
@mergennachin
Copy link
Contributor Author

@pytorchbot cherry-pick --onto release/0.5 -c release

pytorchbot pushed a commit that referenced this pull request Jan 8, 2025
@pytorchbot
Copy link
Collaborator

Cherry picking #7520

The cherry pick PR is at #7548

Details for Dev Infra team Raised by workflow job

SS-JIA pushed a commit that referenced this pull request Jan 13, 2025
Change status to beta in pyproject.toml file (#7520)

(cherry picked from commit 54f0786)

Co-authored-by: Mergen Nachin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants