-
Notifications
You must be signed in to change notification settings - Fork 748
Add utils to replace torchtune SDPA with ET Custom SDPA #7531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: gh/tarun292/2/base
Are you sure you want to change the base?
Conversation
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7531
Note: Links to docs will display an error until the docs builds have been completed. ❌ 4 New FailuresAs of commit 01fa0f8 with merge base 68c0208 ( NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
@tarun292 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
| self.kv_cache.cache_pos.copy_(cache_pos) | ||
|
|
||
| output = self._sdpa(q, k, v, b, s_x, mask=mask) | ||
| if input_pos is None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this might break the non kv cache version of the text decoder, in that case Should be okay actuallyinput_pos is also None
Differential Revision: [D67878161](https://our.internmc.facebook.com/intern/diff/D67878161) [ghstack-poisoned]
|
@tarun292 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Differential Revision: [D67878161](https://our.internmc.facebook.com/intern/diff/D67878161) [ghstack-poisoned]
|
@tarun292 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
Hi @tarun292! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
ghstack-source-id: f733fe2 Pull Request resolved: pytorch/executorch#7531
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Stack from ghstack (oldest at bottom):
Differential Revision: D67878161