Add visualization to devtools #7554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7554
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 54dfe31 with merge base a10eabd ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Erik-Lundell
added
partner: arm
- Add ai-edge-model-explorer as development requirement - Add lightweight wrapper around model-explorer in devtools - Use it in .visualize() call in XNNPack tester - Add tests. The actual call to model-explorer is mocked, since getting it to run in ci did not work out. However, asserting that the model actually loads properly needs visual inspection anyways. Instead, visualization_utils_test.py can be run locally. - Add two context managers for starting model-explorer servers, currently only used for testing but might be useful. Signed-off-by: Erik Lundell <[email protected]> Change-Id: I3fc0efb3a2012b038f699f7737c4d97c5039df40
Erik-Lundell
force-pushed
the
visualization
branch
from
c915cd1 to
3ae2b41
Compare
Olivia-liu
approved these changes
Jan 13, 2025
freddan80
approved these changes
Jan 14, 2025
YIWENX14
pushed a commit
that referenced
this pull request
Jan 28, 2025
- Add ai-edge-model-explorer as development requirement - Add lightweight wrapper around model-explorer in devtools - Use it in .visualize() call in XNNPack tester - Add tests. The actual call to model-explorer is mocked, since getting it to run in ci did not work out. However, asserting that the model actually loads properly needs visual inspection anyways. Instead, visualization_utils_test.py can be run locally. - Add two context managers for starting model-explorer servers, currently only used for testing but might be useful. Signed-off-by: Erik Lundell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See discussion here #6750