-
Notifications
You must be signed in to change notification settings - Fork 706
[ET-VK] Fixing conv2d dw incorrect output when stride != dilation issue. #7571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: gh/trivedivivek/40/base
Are you sure you want to change the base?
Conversation
This diff moves current implementation of conv2d dw as a special case when stride equals dilation in the Vulkan backend of Executorch, since that's the only time this kind of caching is possible. If stride does not equal dilation the old implementation is used. Differential Revision: [D67908916](https://our.internmc.facebook.com/intern/diff/D67908916/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7571
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit 5186361 with merge base 39e8538 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This diff moves current implementation of conv2d dw as a special case when stride equals dilation in the Vulkan backend of Executorch, since that's the only time this kind of caching is possible. If stride does not equal dilation the old implementation is used. Differential Revision: [D67908916](https://our.internmc.facebook.com/intern/diff/D67908916/) ghstack-source-id: 260756038 Pull Request resolved: #7571
|
This pull request was exported from Phabricator. Differential Revision: D67908916 |
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
|
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
Stack from ghstack (oldest at bottom):
This diff moves current implementation of conv2d dw as a special case when stride equals dilation in the Vulkan backend of Executorch, since that's the only time this kind of caching is possible.
If stride does not equal dilation the old implementation is used.
Differential Revision: D67908916