Clean up executorch_print_configuration_summary #7574
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add missing EXECUTORCH_BUILD_ options. s/EXECUTORCH_BUILD_GTESTS/EXECUTORCH_BUILD_TESTS/ . Sort them. Run cmake-format.
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7574
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ⏳ No Failures, 17 PendingAs of commit f3c4ee4 with merge base e1c0bcf ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
swolchok
added
the
release notes: build
swolchok
requested review from
Olivia-liu,
dbort and
shoumikhin
and removed request for
Olivia-liu,
dbort and
shoumikhin
shoumikhin
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add missing
EXECUTORCH_BUILD_options.s/EXECUTORCH_BUILD_GTESTS/EXECUTORCH_BUILD_TESTS/. Sort them. Run cmake-format.Test plan
cmake -S . -B cmake-out -DCMAKE_BUILD_TYPE=Releaseinspect result
compare to
cd cmake-out; cmake -LH ..to make sure we aren't missing moreEXECUTORCH_BUILD_options