Make Tester check shapes of reference and model output #7589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torch.allclose() will broadcast data if neccessary. This means that Tester.run_method_and_compare_outputs() may pass even though a delegate produced an output of wrong shape. Signed-off-by: Oscar Andersson <[email protected]> Change-Id: If62907e0fc69cc28b1f5ce5f8cfd6f31b1870a1e
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7589
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ❌ 1 New FailureAs of commit 9399721 with merge base a059981 ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
oscarandersson8218
added
partner: arm
digantdesai
approved these changes
Jan 10, 2025
Contributor
digantdesai
left a comment
digantdesai
left a comment
There was a problem hiding this comment.
I hope this didn't unearth some hidden failures :p
| for i in range(len(model_output)): | ||
| model = model_output[i] | ||
| ref = ref_output[i] | ||
| assert ( |
Contributor
|
|
YIWENX14
pushed a commit
that referenced
this pull request
Jan 28, 2025
Make Tester check shapes of ref and model output torch.allclose() will broadcast data if neccessary. This means that Tester.run_method_and_compare_outputs() may pass even though a delegate produced an output of wrong shape. Change-Id: If62907e0fc69cc28b1f5ce5f8cfd6f31b1870a1e Signed-off-by: Oscar Andersson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
torch.allclose() will broadcast data if neccessary. This means that Tester.run_method_and_compare_outputs() may pass even though a delegate produced an output of wrong shape.