[ET-VK] Fixing conv2d dw incorrect output when stride != dilation issue. #7595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This diff moves current implementation of conv2d dw as a special case when stride equals dilation in the Vulkan backend of Executorch, since that's the only time this kind of caching is possible. If stride does not equal dilation the old implementation is used. Additional test cases are added to ensure computation is correct when stride != dilation. Differential Revision: [D67908916](https://our.internmc.facebook.com/intern/diff/D67908916/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7595
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit b634b31 with merge base 51a107a ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D67908916 |
This was referenced Jan 10, 2025
…ilation issue." This diff moves current implementation of conv2d dw as a special case when stride equals dilation in the Vulkan backend of Executorch, since that's the only time this kind of caching is possible. If stride does not equal dilation the old implementation is used. Additional test cases are added to ensure computation is correct when stride != dilation. Differential Revision: [D67908916](https://our.internmc.facebook.com/intern/diff/D67908916/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D67908916 |
SS-JIA
approved these changes
Jan 10, 2025
…ilation issue." This diff moves current implementation of conv2d dw as a special case when stride equals dilation in the Vulkan backend of Executorch, since that's the only time this kind of caching is possible. If stride does not equal dilation the old implementation is used. Additional test cases are added to ensure computation is correct when stride != dilation. Differential Revision: [D67908916](https://our.internmc.facebook.com/intern/diff/D67908916/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D67908916 |
…ilation issue." This diff moves current implementation of conv2d dw as a special case when stride equals dilation in the Vulkan backend of Executorch, since that's the only time this kind of caching is possible. If stride does not equal dilation the old implementation is used. Additional test cases are added to ensure computation is correct when stride != dilation. Differential Revision: [D67908916](https://our.internmc.facebook.com/intern/diff/D67908916/) [ghstack-poisoned]
|
This pull request was exported from Phabricator. Differential Revision: D67908916 |
facebook-github-bot
merged commit d790787
into
gh/trivedivivek/41/base
45 of 46 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
trivedivivek
added a commit
that referenced
this pull request
Jan 13, 2025
…ue. (#7628) Pull Request resolved: #7595 This diff moves current implementation of conv2d dw as a special case when stride equals dilation in the Vulkan backend of Executorch, since that's the only time this kind of caching is possible. If stride does not equal dilation the old implementation is used. Additional test cases are added to ensure computation is correct when stride != dilation. ghstack-source-id: 261183385 @exported-using-ghexport Differential Revision: [D67908916](https://our.internmc.facebook.com/intern/diff/D67908916/) Co-authored-by: Vivek Trivedi <[email protected]>
trivedivivek
added a commit
that referenced
this pull request
Jan 13, 2025
…#7629) * [ET-VK] Fixing conv2d dw incorrect output when stride != dilation issue. Pull Request resolved: #7595 This diff moves current implementation of conv2d dw as a special case when stride equals dilation in the Vulkan backend of Executorch, since that's the only time this kind of caching is possible. If stride does not equal dilation the old implementation is used. Additional test cases are added to ensure computation is correct when stride != dilation. ghstack-source-id: 261183385 @exported-using-ghexport Differential Revision: [D67908916](https://our.internmc.facebook.com/intern/diff/D67908916/) * [ET-VK] Making stride equals dilation the default mode for conv2d dw. Pull Request resolved: #7596 This diff makes changes make stride equals dilation the default mode for conv2d dw output op. Adds a different source file to handle stride not equal dilation case. ghstack-source-id: 261183386 Differential Revision: [D67979760](https://our.internmc.facebook.com/intern/diff/D67979760/) * Update conv2d_dw_output_tile.glsl --------- Co-authored-by: Vivek Trivedi <[email protected]>
YIWENX14
pushed a commit
that referenced
this pull request
Jan 28, 2025
…ue. (#7628) Pull Request resolved: #7595 This diff moves current implementation of conv2d dw as a special case when stride equals dilation in the Vulkan backend of Executorch, since that's the only time this kind of caching is possible. If stride does not equal dilation the old implementation is used. Additional test cases are added to ensure computation is correct when stride != dilation. ghstack-source-id: 261183385 @exported-using-ghexport Differential Revision: [D67908916](https://our.internmc.facebook.com/intern/diff/D67908916/) Co-authored-by: Vivek Trivedi <[email protected]>
YIWENX14
pushed a commit
that referenced
this pull request
Jan 28, 2025
…#7629) * [ET-VK] Fixing conv2d dw incorrect output when stride != dilation issue. Pull Request resolved: #7595 This diff moves current implementation of conv2d dw as a special case when stride equals dilation in the Vulkan backend of Executorch, since that's the only time this kind of caching is possible. If stride does not equal dilation the old implementation is used. Additional test cases are added to ensure computation is correct when stride != dilation. ghstack-source-id: 261183385 @exported-using-ghexport Differential Revision: [D67908916](https://our.internmc.facebook.com/intern/diff/D67908916/) * [ET-VK] Making stride equals dilation the default mode for conv2d dw. Pull Request resolved: #7596 This diff makes changes make stride equals dilation the default mode for conv2d dw output op. Adds a different source file to handle stride not equal dilation case. ghstack-source-id: 261183386 Differential Revision: [D67979760](https://our.internmc.facebook.com/intern/diff/D67979760/) * Update conv2d_dw_output_tile.glsl --------- Co-authored-by: Vivek Trivedi <[email protected]>
kedarnath03
pushed a commit
to kedarnath03/executorch
that referenced
this pull request
Jun 25, 2025
This diff moves current implementation of conv2d dw as a special case when stride equals dilation in the Vulkan backend of Executorch, since that's the only time this kind of caching is possible. If stride does not equal dilation the old implementation is used. Additional test cases are added to ensure computation is correct when stride != dilation. Differential Revision: [D67908916](https://our.internmc.facebook.com/intern/diff/D67908916/) ghstack-source-id: 260931966 Pull Request resolved: pytorch/executorch#7595
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This diff moves current implementation of conv2d dw as a special case when stride equals dilation in the Vulkan backend of Executorch, since that's the only time this kind of caching is possible.
If stride does not equal dilation the old implementation is used.
Additional test cases are added to ensure computation is correct when stride != dilation.
Differential Revision: D67908916