Fix broken QNN models on benchmarks #7630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7630
Note: Links to docs will display an error until the docs builds have been completed. This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
guangy10
temporarily deployed
to
upload-benchmark-results
GitHub Actions
Inactive
guangy10
force-pushed
the
fix_qnn_benchmark_models
branch
3 times, most recently
from
1fb46c1 to
b6d8c2b
Compare
guangy10
force-pushed
the
fix_qnn_benchmark_models
branch
from
b6d8c2b to
aa5d2e2
Compare
|
@guangy10 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
cccclai
approved these changes
Jan 23, 2025
There was a problem hiding this comment.
Seems reasonable. @shewu-quic @haowhsu-quic @winskuo-quic for a second look
guangy10
temporarily deployed
to
upload-benchmark-results
GitHub Actions
Inactive
|
The ad-hoc run finished successfully. Will go ahead and merge, let me know if you have questions. cc: @shewu-quic @haowhsu-quic @winskuo-quic |
|
Thank you for helping this! |
YIWENX14
pushed a commit
that referenced
this pull request
Jan 28, 2025
Co-authored-by: Github Executorch <[email protected]>
zonglinpeng
pushed a commit
to zonglinpeng/executorch
that referenced
this pull request
Jan 30, 2025
Co-authored-by: Github Executorch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed edsr that have been failing on nightly benchmark runs: https://github.com/pytorch/executorch/actions/runs/12898498585
Test ad-hoc run for edsr+qnn: https://github.com/pytorch/executorch/actions/runs/12919532695