Skip to content

[dim order] reenbale dim order as default #7682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 17, 2025
Merged

[dim order] reenbale dim order as default #7682

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions backends/vulkan/test/test_vulkan_delegate.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,7 @@ def run_test():

edge_program = to_edge_transform_and_lower(
program,
compile_config=self._edge_compile_config,
transform_passes=[
I64toI32(self._edge_compile_config._skip_dim_order),
],
Expand Down
3 changes: 1 addition & 2 deletions exir/capture/_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,7 @@ class EdgeCompileConfig:
)
_skip_type_promotion: bool = False
# TODO(gasoonjia): remove this
# TODO(T192537614): reenanle dim order as default
_skip_dim_order: bool = True
_skip_dim_order: bool = False


@compatibility(is_backward_compatible=False)
Expand Down
Loading