[devtools/visualization] Add visualize_graph #7721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Erik-Lundell
added
module: devtools
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7721
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 727bf64 with merge base 57ef834 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Collaborator
|
Hi @digantdesai this PR touch non Arm folders, OK? |
digantdesai
reviewed
Jan 17, 2025
Erik-Lundell
force-pushed
the
visualize_graph
branch
2 times, most recently
from
8891df2 to
26f119e
Compare
If a node is created without specifying an overload, A OpOverloadPacket is created, rather than an OpOverload. This works in a GraphModule, but the OpOverloadPacket is not a valid operator type in the _EXIREdgeDialectVerifier, which means that Edge ExportedPrograms can't contain a GraphModule with such ops. In short, specifying using the default overload seems to be the more correct way of creating a custom operator. Signed-off-by: Erik Lundell <[email protected]> Change-Id: I3a1733c0ae88826d88b1e820eaacff765df7fbd2
When working with passes, you might have access to a modified graph_module rather than an exported_program. visualize_graph allows visualization of this graph_module by combining the modified graph_module with an exported_program. Note that the graph_module can't be set directly, a new exported_program needs to be constructed. Additionally, we disable the operator validation for the newly constructed ExportedProgram. This is ok since it is only used for visualization. Signed-off-by: Erik Lundell <[email protected]> Change-Id: I4fad809bf094a1ec70e25534cc0858f9d8d3d225
Erik-Lundell
force-pushed
the
visualize_graph
branch
from
26f119e to
727bf64
Compare
digantdesai
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working with passes, you might have access to a modified graph_module rather than an exported_program. visualize_graph allows visualization of this graph_module by combining the modified graph_module with an exported_program. Note that the graph_module can't be set directly, a new exported_program needs to be constructed.
Additionally, we disable the operator validation for the newly constructed ExportedProgram. This is ok since it is only used for visualization.