[ET-VK][ez] Fix conv2d_pw shared memory buffer not having a constant size
#7729
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t size ## Context `conv2d_pw` was failing to compile on Mac due to the shared memory array not having a constant size. Simply hardcode the workgroup size to fix. Differential Revision: [D68331984](https://our.internmc.facebook.com/intern/diff/D68331984/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7729
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 1 PendingAs of commit c2c66ee with merge base 1a6b7a6 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
SS-JIA
added a commit
that referenced
this pull request
Jan 17, 2025
…t size ## Context `conv2d_pw` was failing to compile on Mac due to the shared memory array not having a constant size. Simply hardcode the workgroup size to fix. Differential Revision: [D68331984](https://our.internmc.facebook.com/intern/diff/D68331984/) ghstack-source-id: 261911463 Pull Request resolved: #7729
|
This pull request was exported from Phabricator. Differential Revision: D68331984 |
trivedivivek
approved these changes
Jan 17, 2025
facebook-github-bot
merged commit 151fb45
into
gh/SS-JIA/169/base
10 of 14 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
SS-JIA
added a commit
that referenced
this pull request
Jan 17, 2025
…t size (#7734) ## Context `conv2d_pw` was failing to compile on Mac due to the shared memory array not having a constant size. Simply hardcode the workgroup size to fix. Differential Revision: [D68331984](https://our.internmc.facebook.com/intern/diff/D68331984/) ghstack-source-id: 261911463 Pull Request resolved: #7729 Co-authored-by: Stephen Jia <[email protected]>
YIWENX14
pushed a commit
that referenced
this pull request
Jan 28, 2025
…t size (#7734) ## Context `conv2d_pw` was failing to compile on Mac due to the shared memory array not having a constant size. Simply hardcode the workgroup size to fix. Differential Revision: [D68331984](https://our.internmc.facebook.com/intern/diff/D68331984/) ghstack-source-id: 261911463 Pull Request resolved: #7729 Co-authored-by: Stephen Jia <[email protected]>
zonglinpeng
pushed a commit
to zonglinpeng/executorch
that referenced
this pull request
Jan 30, 2025
…t size (pytorch#7734) ## Context `conv2d_pw` was failing to compile on Mac due to the shared memory array not having a constant size. Simply hardcode the workgroup size to fix. Differential Revision: [D68331984](https://our.internmc.facebook.com/intern/diff/D68331984/) ghstack-source-id: 261911463 Pull Request resolved: pytorch#7729 Co-authored-by: Stephen Jia <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
conv2d_pwshared memory buffer not having a constant size #7729Context
conv2d_pwwas failing to compile on Mac due to the shared memory array not having a constant size.Simply hardcode the workgroup size to fix.
Differential Revision: D68331984