Skip to content

Support Half/BFloat16 in split_with_sizes. #7758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 23, 2025
Merged

Support Half/BFloat16 in split_with_sizes. #7758

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c803e04
Update
swolchok Jan 18, 2025
d8ff739
Update
swolchok Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions kernels/portable/cpu/op_split_with_sizes_copy.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,8 @@ void split_with_sizes_copy_out(
ScalarType in_type = in.scalar_type();
ScalarType out_type = out[0].scalar_type();

ET_SWITCH_REAL_TYPES_AND(Bool, in_type, ctx, __func__, CTYPE_IN, [&]() {
ET_SWITCH_REAL_TYPES_AND(Bool, out_type, ctx, __func__, CTYPE_OUT, [&]() {
ET_SWITCH_REALHBF16_TYPES(in_type, ctx, __func__, CTYPE_IN, [&]() {
ET_SWITCH_REALHBF16_TYPES(out_type, ctx, __func__, CTYPE_OUT, [&]() {
Copy link
Contributor

@manuelcandales manuelcandales Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing boolean. Use ET_SWITCH_REALHBBF16_TYPES instead

Copy link
Contributor Author

@swolchok swolchok Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed!

const CTYPE_IN* in_data = in.const_data_ptr<CTYPE_IN>();

// Iterate through list of out tensors
Expand Down
Loading