Skip to content

Support Half/BFloat16 in cdist #7800

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
swolchok merged 1 commit into from
Jan 23, 2025
Merged

Support Half/BFloat16 in cdist #7800

swolchok merged 1 commit into from
Jan 23, 2025

Conversation

@swolchok
Copy link
Contributor

@swolchok swolchok commented Jan 21, 2025

Partial fix for #7748.

@swolchok
Update
f538e6c 
[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

swolchok commented Jan 21, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

@pytorch-bot
Copy link

pytorch-bot bot commented Jan 21, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7800

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit f538e6c with merge base 948fba6 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 21, 2025
swolchok added a commit that referenced this pull request Jan 21, 2025
@swolchok
Support Half/BFloat16 in cdist
7c6501b 
Partial fix for #7748.

ghstack-source-id: 81b8638
ghstack-comment-id: 2605573512
Pull Request resolved: #7800
@swolchok swolchok added the release notes: ops & kernels Changes to the opset and any new / changed kernel implementations label Jan 21, 2025
manuelcandales
manuelcandales reviewed Jan 22, 2025
View reviewed changes
kernels/test/op_cdist_forward_test.cpp
out,
l3,
1e-2,
executorch::runtime::testing::internal::kDefaultBFloat16Atol);
Copy link
Contributor

@manuelcandales manuelcandales Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need to pass the default atol here?

Copy link
Contributor Author

@swolchok swolchok Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

macros don't have default arguments

manuelcandales
manuelcandales reviewed Jan 22, 2025
View reviewed changes
runtime/core/exec_aten/testing_util/tensor_util.cpp
return internal::kDefaultHalfAtol;
}
if (t == ScalarType::BFloat16) {
return internal::kDefaultBFloat16Atol;
Copy link
Contributor

@manuelcandales manuelcandales Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great, I wasn't aware of these defaults. Do these play well with the EXPECT_TENSOR_CLOSE_WITH_TOL macro?

Copy link
Contributor Author

@swolchok swolchok Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, though atol matters a lot less to me than rtol in all these diffs

Copy link
Contributor

@manuelcandales manuelcandales Jan 23, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my comment on #7807 , I think you should also introduce kDefaultHalfRtol and kDefaultBFloat16Rtol.

Copy link
Contributor Author

@swolchok swolchok Jan 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replied; 1e-2 is not needed for all ops

@swolchok swolchok merged commit f5ba5bc into main Jan 23, 2025
44 of 47 checks passed
@swolchok swolchok deleted the gh/swolchok/156/head branch January 23, 2025 17:59
YIWENX14 pushed a commit that referenced this pull request Jan 28, 2025
@swolchok @YIWENX14
Support Half/BFloat16 in cdist (#7800)
7c90ff3 
Partial fix for #7748.
zonglinpeng pushed a commit to zonglinpeng/executorch that referenced this pull request Jan 30, 2025
@swolchok
Support Half/BFloat16 in cdist (pytorch#7800)
0ab6e8a 
Partial fix for pytorch#7748.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@manuelcandales manuelcandales manuelcandales approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: ops & kernels Changes to the opset and any new / changed kernel implementations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@swolchok @manuelcandales @facebook-github-bot