Skip to content

[ET-VK] Minor improvements to conv2d pw and dw bounds check. #7815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 27, 2025
Merged

[ET-VK] Minor improvements to conv2d pw and dw bounds check. #7815

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
09626eb
[ET-VK] Minor improvements to conv2d pw and dw bounds check.
trivedivivek Jan 21, 2025
cef6b58
Update on "[ET-VK] Minor improvements to conv2d pw and dw bounds check."
trivedivivek Jan 22, 2025
673792c
Update on "[ET-VK] Minor improvements to conv2d pw and dw bounds check."
trivedivivek Jan 24, 2025
f537bea
Update on "[ET-VK] Minor improvements to conv2d pw and dw bounds check."
trivedivivek Jan 24, 2025
65c879d
Update on "[ET-VK] Minor improvements to conv2d pw and dw bounds check."
trivedivivek Jan 27, 2025
3db13d9
Update on "[ET-VK] Minor improvements to conv2d pw and dw bounds check."
trivedivivek Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion backends/vulkan/runtime/graph/ops/glsl/conv2d_dw.glsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ void main() {
div_by_x % out_limits.y,
div_by_x / out_limits.y);

if (any(greaterThanEqual(pos, out_limits))) {
if (pos.z >= out_limits.z) {
return;
}

Expand Down
2 changes: 1 addition & 1 deletion backends/vulkan/runtime/graph/ops/glsl/conv2d_dw_output_tile.glsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ void main() {
pos.y *= BATCH_SIZE_Y;

// do not process if top pixel does not fit within the output range
if (any(greaterThanEqual(pos, out_limits))) {
if (pos.z >= out_limits.z) {
return;
}

Expand Down
2 changes: 1 addition & 1 deletion backends/vulkan/runtime/graph/ops/glsl/conv2d_dw_sned_output_tile.glsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ void main() {
div_by_x % out_limits.y,
div_by_x / out_limits.y);

if (any(greaterThanEqual(pos, out_limits))) {
if (pos.z >= out_limits.z) {
return;
}

Expand Down
2 changes: 1 addition & 1 deletion backends/vulkan/runtime/graph/ops/glsl/conv2d_pw.glsl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ void main() {

// If the top left position is out of bounds, then this invocation will have
// no work to do.
if (any(greaterThanEqual(ivec3(pos[0], gpos.z), out_limits.xyz))) {
if (gpos.z >= out_limits.z) {
return;
}

Expand Down
Loading