Skip to content

Support Half/BFloat16 in leaky_relu #7825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
swolchok merged 1 commit into from
Jan 22, 2025
Merged

Support Half/BFloat16 in leaky_relu #7825

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion kernels/portable/cpu/op_leaky_relu.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ Tensor& leaky_relu_out(

ET_KERNEL_CHECK(ctx, in_type == out_type, InvalidArgument, out);

ET_SWITCH_FLOAT_TYPES(in_type, ctx, "leaky_relu.out", CTYPE, [&]() {
ET_SWITCH_FLOATHBF16_TYPES(in_type, ctx, "leaky_relu.out", CTYPE, [&]() {
CTYPE negative_slope_casted;
ET_SWITCH_SCALAR_OBJ_TYPES(
sc_type, ctx, "leaky_relu.out", CTYPE_MIN, [&]() {
Expand Down
22 changes: 14 additions & 8 deletions kernels/test/op_leaky_relu_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,15 +29,21 @@ class OpLeakyReluTest : public OperatorTest {
return torch::executor::aten::leaky_relu_outf(
context_, in, negative_slope, out);
}
};
template <ScalarType DTYPE>
void test_leaky_relu_dtype() {
TensorFactory<DTYPE> tf;
Tensor in = tf.ones({2, 2});
Tensor out = tf.zeros({2, 2});

TEST_F(OpLeakyReluTest, SanityCheck) {
TensorFactory<ScalarType::Float> tf;
Tensor in = tf.ones({2, 2});
Tensor out = tf.zeros({2, 2});
Tensor ret = op_leaky_relu_out(in, -0.01, out);

Tensor ret = op_leaky_relu_out(in, -0.01, out);
EXPECT_TENSOR_EQ(out, ret);
EXPECT_TENSOR_EQ(out, tf.ones({2, 2}));
}
};

EXPECT_TENSOR_EQ(out, ret);
EXPECT_TENSOR_EQ(out, tf.ones({2, 2}));
TEST_F(OpLeakyReluTest, SanityCheck) {
#define TEST_ENTRY(ctype, dtype) test_leaky_relu_dtype<ScalarType::dtype>();
ET_FORALL_FLOATHBF16_TYPES(TEST_ENTRY);
#undef TEST_ENTRY
}
Loading