Skip to content

Support Half/BFloat16 in max_pool2d #7829

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
swolchok merged 1 commit into from
Jan 22, 2025
Merged

Support Half/BFloat16 in max_pool2d #7829

swolchok merged 1 commit into from
Jan 22, 2025
+73 −65

Conversation

@swolchok
Copy link
Contributor

@swolchok swolchok commented Jan 22, 2025

Partial fix for #7748.

@swolchok
Update
173ee70 
[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Jan 22, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7829

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 173ee70 with merge base b04912f (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@swolchok
Copy link
Contributor Author

swolchok commented Jan 22, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 22, 2025
swolchok added a commit that referenced this pull request Jan 22, 2025
@swolchok
Support Half/BFloat16 in max_pool2d
26200f7 
Partial fix for #7748.

ghstack-source-id: df2caa0
ghstack-comment-id: 2606039743
Pull Request resolved: #7829
@swolchok swolchok added the release notes: ops & kernels Changes to the opset and any new / changed kernel implementations label Jan 22, 2025
@swolchok swolchok merged commit 5d1595a into main Jan 22, 2025
44 of 47 checks passed
@swolchok swolchok deleted the gh/swolchok/170/head branch January 22, 2025 17:57
pncosta22 added a commit to pncosta22/executorch that referenced this pull request Jan 24, 2025
@pncosta22 @facebook-github-bot
Back out "Support Half/BFloat16 in max_pool2d (pytorch#7829)"
f7ba4e6 
Summary: Temporary fix for broken internal builds.

Reviewed By: RafaelLaya

Differential Revision: D68647398
facebook-github-bot pushed a commit that referenced this pull request Jan 25, 2025
@pncosta22
Back out "Support Half/BFloat16 in max_pool2d (#7829)"
25395b9 
Differential Revision: D68647398

Pull Request resolved: #7955
swolchok added a commit that referenced this pull request Jan 27, 2025
@swolchok
Revert "Back out "Support Half/BFloat16 in max_pool2d (#7829)""
3830da1 
This reverts commit 25395b9. We should be able to land these internally now.

ghstack-source-id: 2ff9d42
ghstack-comment-id: 2617009097
Pull Request resolved: #7978
YIWENX14 pushed a commit that referenced this pull request Jan 28, 2025
@swolchok @YIWENX14
Support Half/BFloat16 in max_pool2d (#7829)
e9c85be 
Partial fix for #7748.
YIWENX14 pushed a commit that referenced this pull request Jan 28, 2025
@pncosta22 @YIWENX14
Back out "Support Half/BFloat16 in max_pool2d (#7829)"
ed9b374 
Differential Revision: D68647398

Pull Request resolved: #7955
zonglinpeng pushed a commit to zonglinpeng/executorch that referenced this pull request Jan 30, 2025
@swolchok
Support Half/BFloat16 in max_pool2d (pytorch#7829)
4245edc 
Partial fix for pytorch#7748.
zonglinpeng pushed a commit to zonglinpeng/executorch that referenced this pull request Jan 30, 2025
@pncosta22
Back out "Support Half/BFloat16 in max_pool2d (pytorch#7829)"
6f7c665 
Differential Revision: D68647398

Pull Request resolved: pytorch#7955
swolchok added a commit that referenced this pull request Jan 31, 2025
@swolchok
Revert "Back out "Support Half/BFloat16 in max_pool2d (#7829)""
109ac29 
This reverts commit 25395b9. We should be able to land these internally now.

ghstack-source-id: 6609cc7
ghstack-comment-id: 2617009097
Pull Request resolved: #7978
swolchok added a commit that referenced this pull request Jan 31, 2025
@swolchok
Revert "Back out "Support Half/BFloat16 in max_pool2d (#7829)""
b32fdcb 
This reverts commit 25395b9. We should be able to land these internally now.

ghstack-source-id: 1180c58
ghstack-comment-id: 2617009097
Pull Request resolved: #7978
swolchok added a commit that referenced this pull request Feb 1, 2025
@swolchok
Revert "Back out "Support Half/BFloat16 in max_pool2d (#7829)"" (#7978)
473c3bd 
This reverts commit 25395b9. We should be able to land these internally now.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@manuelcandales manuelcandales manuelcandales approved these changes

@SS-JIA SS-JIA Awaiting requested review from SS-JIA

@GregoryComer GregoryComer Awaiting requested review from GregoryComer

@lucylq lucylq Awaiting requested review from lucylq

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: ops & kernels Changes to the opset and any new / changed kernel implementations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@swolchok @manuelcandales @facebook-github-bot