Skip to content

Support Half/BFloat16 in native_batch_norm #7842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
swolchok merged 2 commits into from
Jan 23, 2025
Merged

Support Half/BFloat16 in native_batch_norm #7842

swolchok merged 2 commits into from
Jan 23, 2025

Conversation

@swolchok
Copy link
Contributor

@swolchok swolchok commented Jan 22, 2025 •
edited
Loading

No description provided.

@swolchok
Update
61c54c2 
[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

swolchok commented Jan 22, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

@pytorch-bot
Copy link

pytorch-bot bot commented Jan 22, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7842

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure

As of commit 05700c8 with merge base 6fe6870 (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 22, 2025
swolchok added a commit that referenced this pull request Jan 22, 2025
@swolchok
Support Half/BFloat16 in native_batch_norm
00b9b10 
ghstack-source-id: 444bf70
ghstack-comment-id: 2608254545
Pull Request resolved: #7842
@swolchok swolchok added the release notes: ops & kernels Changes to the opset and any new / changed kernel implementations label Jan 22, 2025
swolchok
swolchok commented Jan 22, 2025
View reviewed changes
kernels/test/op_native_batch_norm_test.cpp Outdated
2e-2,
executorch::runtime::testing::internal::kDefaultAtol);
EXPECT_TENSOR_CLOSE_WITH_TOL(
out1,
Copy link
Contributor Author

@swolchok swolchok Jan 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yikes, forgot to amend

@swolchok
Update
05700c8 
[ghstack-poisoned]
swolchok added a commit that referenced this pull request Jan 22, 2025
@swolchok
Support Half/BFloat16 in native_batch_norm
6281c49 
ghstack-source-id: 59f5517
ghstack-comment-id: 2608254545
Pull Request resolved: #7842
@swolchok swolchok merged commit affd5c0 into main Jan 23, 2025
44 of 45 checks passed
@swolchok swolchok deleted the gh/swolchok/172/head branch January 23, 2025 18:11
YIWENX14 pushed a commit that referenced this pull request Jan 28, 2025
@swolchok @YIWENX14
Support Half/BFloat16 in native_batch_norm (#7842)
bc2de23
zonglinpeng pushed a commit to zonglinpeng/executorch that referenced this pull request Jan 30, 2025
@swolchok
Support Half/BFloat16 in native_batch_norm (pytorch#7842)
4809f7f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@manuelcandales manuelcandales manuelcandales approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: ops & kernels Changes to the opset and any new / changed kernel implementations

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@swolchok @manuelcandales @facebook-github-bot