Skip to content

[ET-VK][ez] Update requirements for partitioning to_dim_order_copy #7896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 23, 2025
Merged

[ET-VK][ez] Update requirements for partitioning to_dim_order_copy #7896

merged 1 commit into from
Jan 23, 2025

Conversation

@pytorchbot
Copy link
Collaborator

This PR was created by the merge bot to help merge the original PR into the main branch.
ghstack PR number: #7859
^ Please use this as the source of truth for the PR details, comments, and reviews
ghstack PR base: https://github.com/pytorch/executorch/tree/gh/SS-JIA/171/base
ghstack PR head: https://github.com/pytorch/executorch/tree/gh/SS-JIA/171/head
Merge bot PR base: https://github.com/pytorch/executorch/tree/main
Merge bot PR head: https://github.com/pytorch/executorch/tree/gh/SS-JIA/171/orig
@diff-train-skip-merge

@SS-JIA
[ET-VK][ez] Update requirements for partitioning to_dim_order_copy
a038de6 
Pull Request resolved: #7859

## Context

The previous registration of the to dim order copy op is incorrect. Currently, there is no implementation for the op in the Vulkan backend, but since Vulkan manages memory layout internally the op node can be removed as long as the only thing being changed is dim order.

In some instances the op can be used to modify the dtype, in which case it will not be removed and the Vulkan delegate cannot execute the op correctly. Therefore, update the registration of the op to reflect this restriction.

This diff should unblock enabling dim order ops for Vulkan.
ghstack-source-id: 262710507
@exported-using-ghexport

Differential Revision: [D68528213](https://our.internmc.facebook.com/intern/diff/D68528213/)
@pytorch-bot
Copy link

pytorch-bot bot commented Jan 23, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7896

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 36 Pending

As of commit a038de6 with merge base f73b8cf (image):

NEW FAILURE - The following job has failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 23, 2025
@github-actions
Copy link

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@kirklandsign kirklandsign merged commit 5ee5f2f into main Jan 23, 2025
40 of 43 checks passed
@kirklandsign kirklandsign deleted the gh/SS-JIA/171/orig branch January 23, 2025 19:33
@SS-JIA
Copy link
Contributor

SS-JIA commented Jan 24, 2025

@pytorchbot cherry-pick --onto release/0.5 -c fixnewfeature

@pytorchbot
Copy link
Collaborator Author

Cherry picking #7896

The cherry pick PR is at #7949 and it is recommended to link a fixnewfeature cherry pick PR with an issue. The following tracker issues are updated:

Details for Dev Infra team Raised by workflow job

@pytorchbot pytorchbot mentioned this pull request Jan 24, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kirklandsign kirklandsign kirklandsign approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pytorchbot @SS-JIA @kirklandsign @facebook-github-bot