Make setup.sh sourceable to run single functions #7934
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If setup is run like `./examples/arm/setup.sh` ..., it works like before. If it is run like `source ./examples/arm/setup.sh`, the functions in the script can be run afterwards, for example you can just run `setup_toolchain` To increase modularity, I broke out creating setup_path.sh to its own function. This avoids breaking setup_path.sh if setting up the toolchain and FVP fails/ is aborted. Signed-off-by: Erik Lundell <[email protected]> Change-Id: I79556d3c2c451157b9ba3606596945b2b70d2828
Erik-Lundell
added
partner: arm
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7934
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 1 PendingAs of commit 6924546 with merge base 3eea1f1 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
digantdesai
reviewed
Jan 28, 2025
zingo
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If setup is run like
./examples/arm/setup.sh..., it works like before. If it is run likesource ./examples/arm/setup.sh, the functions in the script can be run afterwards, for example you can just runsetup_toolchainTo increase modularity, I broke out creating setup_path.sh to its own function.
This avoids breaking setup_path.sh if setting up the toolchain and FVP fails/ is aborted.
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218