Fix helper method for getting input names #7996
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous version missed ConstantInputs which caused problems in the runtime when the provided inputs did not match the GraphSignature. You could argue that having to provide constant inputs that are already encoded in the graph as arguments is unnecessary. However, this solution is more general and does not stop us from adding a pass that prunes unwanted inputs from the graph signature in the future. (if that is possible) Encountered an issue with too long input names, had to rename some parameters in testcases to shorter names (added ticket to adress this, #MLETORCH-628) Signed-off-by: Erik Lundell <[email protected]> Change-Id: Idf39d94aa1340ace655c1393b97f4616aec250db
Erik-Lundell
added
partner: arm
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/7996
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 Cancelled Job, 1 PendingAs of commit 224f3d6 with merge base 3eea1f1 ( CANCELLED JOB - The following job was cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
digantdesai
approved these changes
Jan 28, 2025
zingo
approved these changes
Jan 29, 2025
Collaborator
|
macos job seems unrelated and fail on other PR and on "main" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous version missed ConstantInputs which
caused problems in the runtime when the provided
inputs did not match the GraphSignature.
You could argue that having to provide constant inputs that are already encoded in the graph as arguments is unnecessary. However, this solution is more general and does not stop us from adding a pass that prunes unwanted inputs from the graph signature in the future. (if that is possible)
Encountered an issue with too long input names,
had to rename some parameters in testcases to
shorter names.
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218