Skip to content

fix missing if constexpr in optimized gelu (unbreak sync of D68745515/#7987) #8011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
swolchok merged 1 commit into from
Jan 28, 2025
Merged

fix missing if constexpr in optimized gelu (unbreak sync of D68745515/#7987) #8011

swolchok merged 1 commit into from
Jan 28, 2025

Conversation

@swolchok
Copy link
Contributor

@swolchok swolchok commented Jan 28, 2025

The code gated under this if does disallowed static_casts if the if condition doesn't pass; this is what if constexpr is for.

@swolchok
Update
4740f9e 
[ghstack-poisoned]
@swolchok
Copy link
Contributor Author

swolchok commented Jan 28, 2025 •
edited
Loading

Stack from ghstack (oldest at bottom):

@pytorch-bot
Copy link

pytorch-bot bot commented Jan 28, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8011

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 2 Pending

As of commit 4740f9e with merge base 3540723 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 28, 2025
swolchok added a commit that referenced this pull request Jan 28, 2025
@swolchok
fix missing if constexpr in optimized gelu (unbreak sync of D68745515/
ab764cd 
#7987)

The code gated under this `if` does disallowed static_casts if the `if` condition doesn't pass; this is what `if constexpr` is for.

ghstack-source-id: 8286f21
ghstack-comment-id: 2620014279
Pull Request resolved: #8011
@swolchok
Copy link
Contributor Author

swolchok commented Jan 28, 2025

landing despite full CI not running because this change is isolated and I've manually tested it

@swolchok swolchok merged commit 520e0bc into main Jan 28, 2025
7 of 9 checks passed
@swolchok swolchok deleted the gh/swolchok/213/head branch January 28, 2025 21:03
YIWENX14 pushed a commit that referenced this pull request Jan 28, 2025
@swolchok @YIWENX14
fix missing if constexpr in optimized gelu (unbreak sync of D68745515/
3aa76fa 
#7987) (#8011)

The code gated under this `if` does disallowed `static_cast`s if the `if` condition doesn't pass; this is what `if constexpr` is for.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GregoryComer GregoryComer GregoryComer approved these changes

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. topic: not user facing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@swolchok @GregoryComer @facebook-github-bot