Add fuse batchnorm pass #8028
Merged
Add fuse batchnorm pass #8028
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ExportPasses that need to be initated with an ExportedProgram can currently not be tested in a convenient way. This patch subclasses RunPasses, adding a parameter, `passes_with_exported_program`, that can be used just like `pass_list` but are initiated with an exported program before they are run. The functionality is tested in new tests for the CastInt64Pass and InsertTableOpsPass Signed-off-by: Erik Lundell <[email protected]> Change-Id: I1712d86abe7cc3672c343db568df1264c0b9133e
The pass differs from existing fuse passes since they use the get_attr node which is not supported by ArmBackend. Instead, we update the existing parameters. Also adds tests. Change-Id: Iad6d70e632191d74d96df62b1837d37fe60e7d3a
Erik-Lundell
added
partner: arm
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8028
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New Failure, 2 Cancelled Jobs, 1 PendingAs of commit d3c6a60 with merge base c5fea7e ( NEW FAILURE - The following job has failed:
CANCELLED JOBS - The following jobs were cancelled. Please retry:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
manuelcandales
added
the
triaged
digantdesai
reviewed
Jan 30, 2025
zingo
approved these changes
Jan 31, 2025
Collaborator
|
macos unrealted |
digantdesai
reviewed
Jan 31, 2025
Contributor
digantdesai
left a comment
digantdesai
left a comment
There was a problem hiding this comment.
Dang missed the train on this one :p
| self.add_pass(ConvertMeanDimToAveragePoolPass()) | ||
| self.add_pass(DecomposeDivPass()) | ||
| self.add_pass(DecomposeSoftmaxesPass()) | ||
| self.add_pass(FuseBatchnorm2DPass(exported_program)) |
Collaborator
Author
There was a problem hiding this comment.
This is already done in the BI case, in prepare_pt2e I believe
| from executorch.backends.arm.test.tester.arm_tester import ArmTester, RunPasses | ||
|
|
||
|
|
||
| class Int64Model(torch.nn.Module): |
Collaborator
Author
There was a problem hiding this comment.
A scalar always becomes int64
| z = self.conv2d2(x) | ||
| a = self.batch_norm2d( | ||
| y | ||
| ) # Can't be fused since paramters of conv2d2 have multiple users. |
Contributor
There was a problem hiding this comment.
why is this a real constraint? i.e.
y = conv2d2(x1)
a = bn2d(y)
return a
Collaborator
Author
There was a problem hiding this comment.
Since we update the weights of the convolution, it will produce different output. The new output will only be correct for the user that had the bn.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pass differs from existing fuse passes since they
use the get_attr node which is not supported by ArmBackend.
Instead, we update the existing parameters.
Also adds tests.
To test the batchnorm pass, I extended RunPasses, adding a parameter,
passes_with_exported_program, that can be used justlike
pass_listbut are initiated with anexported program before they are run.
The functionality is tested in new tests for the
CastInt64Pass and InsertTableOpsPass
cc @digantdesai @freddan80 @per @zingo @oscarandersson8218