Skip to content

Conversation

@billmguo
Copy link
Contributor

Summary: add argmin, add_ ops annontation

Differential Revision: D68811662

@pytorch-bot
Copy link

pytorch-bot bot commented Jan 29, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8040

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 New Failure, 1 Cancelled Job, 1 Unrelated Failure

As of commit e0815e2 with merge base 0a936e0 (image):

NEW FAILURE - The following job has failed:

CANCELLED JOB - The following job was cancelled. Please retry:

BROKEN TRUNK - The following job failed but were present on the merge base:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jan 29, 2025
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68811662

@billmguo
Copy link
Contributor Author

@pytorchbot label "topic: not user facing"

@billmguo
Copy link
Contributor Author

@pytorchbot label "topic: not user facing"

billmguo added a commit to billmguo/executorch that referenced this pull request Jan 30, 2025
Summary:
pytorch#8040
add argmin, add_ ops  annontation

Differential Revision: D68811662
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68811662

billmguo added a commit to billmguo/executorch that referenced this pull request Jan 30, 2025
Summary:

pytorch#8040
add argmin, add_ ops  annontation

Differential Revision: D68811662
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68811662

billmguo added a commit to billmguo/executorch that referenced this pull request Jan 30, 2025
Summary:

pytorch#8040
add argmin, add_ ops  annontation

Differential Revision: D68811662
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68811662

1 similar comment
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68811662

billmguo added a commit to billmguo/executorch that referenced this pull request Jan 31, 2025
Summary:
Pull Request resolved: pytorch#8040

pytorch#8040
add argmin, add_ ops  annontation

Differential Revision: D68811662
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68811662

billmguo added a commit to billmguo/executorch that referenced this pull request Jan 31, 2025
Summary:
Pull Request resolved: pytorch#8040

pytorch#8040
add argmin, add_ ops  annontation

Differential Revision: D68811662
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68811662

billmguo added a commit to billmguo/executorch that referenced this pull request Jan 31, 2025
Summary:
Pull Request resolved: pytorch#8040

pytorch#8040
add argmin, add_ ops  annontation

Differential Revision: D68811662
billmguo added a commit to billmguo/executorch that referenced this pull request Jan 31, 2025
Summary:
Pull Request resolved: pytorch#8040

pytorch#8040
add argmin, add_ ops  annontation

Differential Revision: D68811662
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68811662

billmguo added a commit to billmguo/executorch that referenced this pull request Jan 31, 2025
Summary:
Pull Request resolved: pytorch#8040

pytorch#8040
add argmin, add_ ops  annontation

Differential Revision: D68811662
Copy link
Collaborator

@shewu-quic shewu-quic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your efforts.

@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68811662

billmguo added a commit to billmguo/executorch that referenced this pull request Feb 3, 2025
Summary:
Pull Request resolved: pytorch#8040

pytorch#8040
add argmin, add_ ops  annontation

Differential Revision: D68811662
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68811662

billmguo added a commit to billmguo/executorch that referenced this pull request Feb 3, 2025
Summary:
Pull Request resolved: pytorch#8040

pytorch#8040
add argmin, add_ ops  annontation

Differential Revision: D68811662
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68811662

billmguo added a commit to billmguo/executorch that referenced this pull request Feb 3, 2025
Summary:
Pull Request resolved: pytorch#8040

pytorch#8040
add argmin, add_ ops  annontation

Differential Revision: D68811662
billmguo added a commit to billmguo/executorch that referenced this pull request Feb 3, 2025
Summary:
Pull Request resolved: pytorch#8040

pytorch#8040
add argmin, add_ ops  annontation

Differential Revision: D68811662
billmguo added a commit to billmguo/executorch that referenced this pull request Feb 3, 2025
Summary:

pytorch#8040
add argmin, add_ ops  annontation

Differential Revision: D68811662
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68811662

Summary:

pytorch#8040
add argmin, add_ ops  annontation

Differential Revision: D68811662
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D68811662

Copy link
Collaborator

@shewu-quic shewu-quic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@cccclai cccclai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@facebook-github-bot facebook-github-bot merged commit 821a2fe into pytorch:main Feb 4, 2025
43 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. fb-exported topic: not user facing

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants