Add strict=True explicit flag to Executorch invocations to torch.export.export
#8190
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8190
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ⏳ No Failures, 11 PendingAs of commit a55b2e6 with merge base 3e64c4e ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D69068797 |
Contributor
Author
|
@pytorchbot label "topic: not user facing" |
gmagogsfm
added a commit
to gmagogsfm/executorch-1
that referenced
this pull request
Feb 5, 2025
Summary: Pull Request resolved: pytorch#8190 Reviewed By: avikchaudhuri Differential Revision: D69068797
gmagogsfm
force-pushed
the
export-D69068797
branch
from
20e82e3 to
b57ae5b
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D69068797 |
gmagogsfm
changed the title
strict=True explicit flag to Executorch invocations to torch.export.export
iseeyuan
approved these changes
Feb 5, 2025
Contributor
iseeyuan
left a comment
iseeyuan
left a comment
There was a problem hiding this comment.
LGTM. Would we moved to strict=False as suggested?
Summary: Pull Request resolved: pytorch#8190 Reviewed By: avikchaudhuri, iseeyuan Differential Revision: D69068797
gmagogsfm
force-pushed
the
export-D69068797
branch
from
b57ae5b to
a55b2e6
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D69068797 |
This was referenced Feb 11, 2025
This was referenced Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Differential Revision: D69068797