Skip to content

Arm backend: Enable numerical testing of quantized rshift #8371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zingo merged 1 commit into from
Feb 13, 2025
Merged

Arm backend: Enable numerical testing of quantized rshift #8371

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 16 additions & 14 deletions backends/arm/test/ops/test_rshift.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# Copyright 2024 Arm Limited and/or its affiliates.
# Copyright 2024-2025 Arm Limited and/or its affiliates.
# All rights reserved.
#
# This source code is licensed under the BSD-style license found in the
Expand All @@ -7,22 +7,20 @@
import unittest

import torch
from executorch.backends.arm.test import common
from executorch.backends.arm.test import common, conftest
from executorch.backends.arm.test.tester.arm_tester import ArmTester
from parameterized import parameterized


class TestRshift(unittest.TestCase):
"""
Tests arithmetic right shift
"""
"""Tests arithmetic right shift"""

class Rshift(torch.nn.Module):
test_data = [
((torch.IntTensor(5, 5), 2),),
((torch.IntTensor(1, 2, 3, 4), 3),),
((torch.CharTensor(1, 12, 3, 4), 1),),
((torch.ShortTensor(1, 5, 3, 4), 5),),
((torch.CharTensor(10, 12, 3, 4), 1),),
]

def forward(self, x: torch.Tensor, shift: int):
Expand Down Expand Up @@ -52,8 +50,7 @@ def _test_rshift_tosa_BI(self, test_data):
.export()
.to_edge_transform_and_lower()
.to_executorch()
# TODO MLETORCH-250 Increase flexibility of ArmTester to handle int IO
# .run_method_and_compare_outputs(inputs=test_data)
.run_method_and_compare_outputs(inputs=test_data)
)

def _test_rshift_ethosu_BI(self, test_data, compile_spec):
Expand All @@ -67,6 +64,7 @@ def _test_rshift_ethosu_BI(self, test_data, compile_spec):
.export()
.to_edge_transform_and_lower()
.to_executorch()
.serialize()
)

@parameterized.expand(Rshift.test_data)
Expand All @@ -77,14 +75,18 @@ def test_rshift_tosa_MI(self, test_data):
def test_rshift_tosa_BI(self, test_data):
self._test_rshift_tosa_BI(test_data)

# TODO Enable FVP testing
@parameterized.expand(Rshift.test_data)
# TODO: MLETORCH-644 - Add support for INT16 input/output
@parameterized.expand(Rshift.test_data[:-1])
def test_rshift_u55_BI(self, test_data):
compile_spec = common.get_u55_compile_spec()
self._test_rshift_ethosu_BI(test_data, compile_spec)
tester = self._test_rshift_ethosu_BI(test_data, compile_spec)
if conftest.is_option_enabled("corstone_fvp"):
tester.run_method_and_compare_outputs(atol=1, inputs=test_data)

# TODO Enable FVP testing
@parameterized.expand(Rshift.test_data)
# TODO: MLETORCH-644 - Add support for INT16 input/output
@parameterized.expand(Rshift.test_data[:-1])
def test_rshift_u85_BI(self, test_data):
compile_spec = common.get_u85_compile_spec()
self._test_rshift_ethosu_BI(test_data, compile_spec)
tester = self._test_rshift_ethosu_BI(test_data, compile_spec)
if conftest.is_option_enabled("corstone_fvp"):
tester.run_method_and_compare_outputs(inputs=test_data)
Loading