Mention the PR author in mergebot PRs #8390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Stack from ghstack (oldest at bottom): |
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8390
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit e7f83c0 with merge base 85231f5 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
kirklandsign
approved these changes
Feb 12, 2025
kirklandsign
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully, this should help prevent mergebot PRs from being unnoticed by generating a GitHub notification to the author.
Test Plan: Use ghstack to push a PR (get something like gh/kirklandsign/17/head).
In
.github/scripts/propose_ghstack_orig_pr.py, removeprint("The PR (and stack above) is not merged yet, skipping")andreturnafter it.Then
export GITHUB_TOKEN=python .github/scripts/propose_ghstack_orig_pr.py --repo pytorch/executorch --ref refs/heads/gh/kirklandsign/17/head