Add -Wno-global-constructors -Wno-shadow to fft_r2c op target #8427
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Need to suppress these warnings to unbreak builds; looks like this is what PyTorch core does. Differential Revision: [D69470437](https://our.internmc.facebook.com/intern/diff/D69470437/) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8427
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 New FailureAs of commit b7d65bc with merge base 0beadcc ( NEW FAILURE - The following job has failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D69470437 |
swolchok
pushed a commit
that referenced
this pull request
Feb 12, 2025
Need to suppress these warnings to unbreak builds; looks like this is what PyTorch core does. Differential Revision: [D69470437](https://our.internmc.facebook.com/intern/diff/D69470437/) ghstack-source-id: 266120755 Pull Request resolved: #8427
swolchok
changed the title
larryliu0820
approved these changes
Feb 12, 2025
tarun292
approved these changes
Feb 12, 2025
facebook-github-bot
merged commit 4cea4c3
into
gh/swolchok/258/base
46 of 50 checks passed
facebook-github-bot
temporarily deployed
to
cherry-pick-bot
GitHub Actions
Inactive
swolchok
pushed a commit
that referenced
this pull request
Feb 13, 2025
Need to suppress these warnings to unbreak builds; looks like this is what PyTorch core does. Differential Revision: [D69470437](https://our.internmc.facebook.com/intern/diff/D69470437/) ghstack-source-id: 266120755 Pull Request resolved: #8427
swolchok
pushed a commit
that referenced
this pull request
Feb 13, 2025
Add -Wno-global-constructors -Wno-shadow to op targets Need to suppress these warnings to unbreak builds; looks like this is what PyTorch core does. Differential Revision: [D69470437](https://our.internmc.facebook.com/intern/diff/D69470437/) ghstack-source-id: 266120755 Pull Request resolved: #8427 Co-authored-by: Github Executorch <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Need to suppress these warnings to unbreak builds; looks like this is what PyTorch core does.
Differential Revision: D69470437