Update quantized aot_lib's visibility targets to include ExecuTorch clients #8453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8453
Note: Links to docs will display an error until the docs builds have been completed. ✅ You can merge normally! (2 Unrelated Failures)As of commit 0d14135 with merge base b71d873 ( BROKEN TRUNK - The following jobs failed but were present on the merge base:👉 Rebase onto the `viable/strict` branch to avoid these failures
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D69572954 |
luyich
force-pushed
the
export-D69572954
branch
from
42643b9 to
74d645d
Compare
luyich
pushed a commit
to luyich/executorch
that referenced
this pull request
Feb 13, 2025
Summary: Pull Request resolved: pytorch#8453 Differential Revision: D69572954
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D69572954 |
mcr229
reviewed
Feb 14, 2025
kernels/quantized/targets.bzl
Outdated
| name = "aot_lib", | ||
| yaml_target = ":quantized.yaml", | ||
| visibility = ["//executorch/..."], | ||
| visibility = ["//executorch/...","@EXECUTORCH_CLIENTS"], |
Contributor
There was a problem hiding this comment.
Suggested change
| visibility = ["//executorch/...","@EXECUTORCH_CLIENTS"], | |
| visibility = [ | |
| "//executorch/...", | |
| "@EXECUTORCH_CLIENTS", | |
| ], |
mcr229
approved these changes
Feb 14, 2025
Contributor
mcr229
left a comment
mcr229
left a comment
There was a problem hiding this comment.
stamping to unblock, but please take a look at the nit
luyich
force-pushed
the
export-D69572954
branch
from
74d645d to
856bd31
Compare
luyich
pushed a commit
to luyich/executorch
that referenced
this pull request
Feb 14, 2025
Summary: Export llama 1b from minymal (for testing purpose fixed shape of 1*len*2048) is used. This is build on based on the llava example Reviewed By: asleep, mcr229 Differential Revision: D69572954
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D69572954 |
larryliu0820
changed the title
Summary: Export llama 1b from minymal (for testing purpose fixed shape of 1*len*2048) is used. This is build on based on the llava example Reviewed By: asleep, mcr229 Differential Revision: D69572954
luyich
force-pushed
the
export-D69572954
branch
from
856bd31 to
0d14135
Compare
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D69572954 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As titled.
Differential Revision:
D69572954
Privacy Context Container: L1281892