Skip to content

Arm backend: Add missing __init__.py to passes #8592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
oscarandersson8218 wants to merge 1 commit into from
Closed

Arm backend: Add missing __init__.py to passes #8592

oscarandersson8218 wants to merge 1 commit into from

Conversation

@oscarandersson8218
Copy link
Collaborator

@oscarandersson8218 oscarandersson8218 commented Feb 20, 2025 •
edited by pytorch-bot bot
Loading

Summary

backends/arm/_passes missed an init file which caused pyre to not find imports from _passes.

cc @digantdesai @freddan80 @per @zingo

@pytorch-bot
Copy link

pytorch-bot bot commented Feb 20, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8592

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 1cf77cb with merge base 07266f9 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Feb 20, 2025
@oscarandersson8218 oscarandersson8218 added partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm ciflow/trunk topic: not user facing labels Feb 20, 2025
@oscarandersson8218
Copy link
Collaborator Author

oscarandersson8218 commented Feb 20, 2025

@digantdesai I guess it's safest if you import this and run your internal checks so I don't break anything?

@swolchok swolchok added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Feb 20, 2025
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Feb 21, 2025

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

1 similar comment
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Feb 21, 2025

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Feb 26, 2025

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@digantdesai
Copy link
Contributor

digantdesai commented Feb 26, 2025

Sorry the import tool keeps failing ...

@digantdesai
Copy link
Contributor

digantdesai commented Feb 26, 2025

Looks good for internal CI

@oscarandersson8218 oscarandersson8218 force-pushed the arm-passes-init branch 2 times, most recently from ad04193 to e9426bc Compare February 28, 2025 16:22
@oscarandersson8218
Copy link
Collaborator Author

oscarandersson8218 commented Mar 10, 2025

Unrelated CI failures.

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Mar 21, 2025

@digantdesai has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

digantdesai
digantdesai approved these changes Mar 21, 2025
View reviewed changes
@digantdesai
Copy link
Contributor

digantdesai commented Mar 21, 2025

LGTM, internal tests are also happy, just rebased, feel free to merge it once the CI is green. Thanks for this, imports are cleaner now :)

@zingo zingo force-pushed the arm-passes-init branch from 061280a to 25e17a0 Compare March 25, 2025 07:58
@oscarandersson8218
Copy link
Collaborator Author

oscarandersson8218 commented Mar 26, 2025

@digantdesai I guess you need to import it again?

@oscarandersson8218 @zingo
Add missing __init__.py to passes
1cf77cb 
backends/arm/_passes missed an init file which caused pyre to not find
imports from _passes.

Signed-off-by: Oscar Andersson <[email protected]>
Change-Id: I80e0c2071844ec0fefeb9fd44f9471ed1be32228
@zingo zingo force-pushed the arm-passes-init branch from 268fc7e to 1cf77cb Compare March 27, 2025 07:42
@oscarandersson8218
Copy link
Collaborator Author

oscarandersson8218 commented Mar 27, 2025

Closing this and creating a new one.

@zingo zingo mentioned this pull request Mar 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@digantdesai digantdesai digantdesai approved these changes

@zingo zingo zingo approved these changes

Assignees

No one assigned

Labels

ciflow/trunk CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. partner: arm For backend delegation, kernels, demo, etc. from the 3rd-party partner, Arm topic: not user facing triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@oscarandersson8218 @facebook-github-bot @digantdesai @zingo @swolchok