Skip to content

[ET-VK] Adding reserve and append functions to SpecVarList #8633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 25, 2025
Merged

[ET-VK] Adding reserve and append functions to SpecVarList #8633

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5053171
[EK-VT] Adding reserve and append functions to SpecVarList
trivedivivek Feb 22, 2025
86c6dbb
Update on "[EK-VT] Adding reserve and append functions to SpecVarList"
trivedivivek Feb 22, 2025
d7f7d8d
Update on "[ET-VK] Adding reserve and append functions to SpecVarList"
trivedivivek Feb 24, 2025
ebcb079
Update on "[ET-VK] Adding reserve and append functions to SpecVarList"
trivedivivek Feb 24, 2025
c186865
Update on "[ET-VK] Adding reserve and append functions to SpecVarList"
trivedivivek Feb 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions backends/vulkan/runtime/vk_api/Pipeline.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,14 @@ void SpecVarList::append(const SpecVarList& other) {
vars.insert(vars.end(), other.vars.begin(), other.vars.end());
}

void SpecVarList::reserve(const size_t size) {
vars.reserve(size);
}

void SpecVarList::append(const SpecVar& other) {
vars.push_back(other);
}

std::vector<VkSpecializationMapEntry> SpecVarList::generate_map_entries()
const {
std::vector<VkSpecializationMapEntry> map_entries;
Expand Down
4 changes: 4 additions & 0 deletions backends/vulkan/runtime/vk_api/Pipeline.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,10 @@ class SpecVarList final {

void append(const SpecVarList& other);

void reserve(const size_t size);

void append(const SpecVar& other);

std::vector<VkSpecializationMapEntry> generate_map_entries() const;

friend bool operator==(const SpecVarList& lhs, const SpecVarList& rhs);
Expand Down
Loading