merge q_8w_linear and main functions in q_8w_linear shader #8704
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: The function defs used to live in a separate header file before D61309097 (pytorch#5492), but were moved to the shader file directly to mirror a similar refactoring for the fp linear shader. It's easier to reason about the shader without having to jump back and forth from the minimal main() functions to the q_8w_linear functions. Differential Revision: D70127663
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/8704
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit dc0580e with merge base f3fc096 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
facebook-github-bot
added
the
CLA Signed
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D70127663 |
yipjustin
approved these changes
Mar 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The function defs used to live in a separate header file before D61309097 (#5492), but were moved to the shader file directly to mirror a similar refactoring for the fp linear shader.
It's easier to reason about the shader without having to jump back and forth from the minimal main() functions to the q_8w_linear functions.
Differential Revision: D70127663